Issue Bug Closed

#89152renderType='selectTree' generates warning with single value select

Thomas Luzat 09/11/19, 17:24 updated 10/04/22, 14:00

Description

When configuring a ‘select’ field like this:

‘config’ => [
‘minitems’ => 1,
‘maxitems’ => 1,
‘type’ => ‘select’,
‘renderType’ => ‘selectTree’,
‘foreign_table’ => ‘foo’,
‘treeConfig’ => [
‘parentField’ => ‘parent’,
],
],

… TYPO3 9.5.9 (and probably 8, possibly 10) generates a warning (which may be converted to an exception) when rendering the tree in the backend:

PHP Warning: implode(): Invalid arguments passed in /var/www/htdocs/web/typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php line 164

This was introduced earlier in 2019 with 18411d12528454d1b71574da5a86837bc11e189e: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60415

Changing the line

$html[] = ‘ value=”’ . htmlspecialchars(implode(‘,’, $parameterArray[‘itemFormElValue’])) . ‘”’;

to

$html[] = ‘ value=”’ . htmlspecialchars(is_array($parameterArray[‘itemFormElValue’]) ? implode(‘,’, $parameterArray[‘itemFormElValue’]) : $parameterArray[‘itemFormElValue’]) . ‘”’;

seems to reasonably fix the case here.

Reviews 6