Issue Bug Closed

#91369AbstractProvider->identifier string?

Tomas Norre Mikkelsen 05/12/20, 17:36 updated 05/30/21, 00:05

Description

I’ve been doing some PHPStan work with the TYPO3 Crawler, and found that I use

$crawlerConfiguration = BackendUtility::getRecordWSOL($this->table, $this->identifier); (1) Where the $this->identifier is a string as it’s inherited from TYPO3\CMS\Backend\ContextMenu\ItemProviders\AbstractProvider (2) but should have been int according to BackendUtility::getRecordWSOL().

I’m not sure if I’m doing a faulty implementation or if the AbstractProvider Identifier should be different.

Hope you can help shed some light on this.

1) https://github.com/AOEpeople/crawler/blob/master/Classes/ContextMenu/ItemProvider.php#L70
2) https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Classes/ContextMenu/ItemProviders/AbstractProvider.php#L74

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.