#91432PageRepository PageRepository_hidDelWhere cache should consider more attributes
Description
Looking into PageRepository::enableFields reveals that the cache-identifier probably should have more information, e.g. some “state-hash” of the currently applied Context.
Currently considered
- show-hidden – context:visibility/includeHiddenPages
- workspace ID – context.workspace.id
Probably not considered
- starttime/endtime – context:date/accessTime
fe_group – context:frontend.user/groupIds (has it’s own cache – but does not modifyPageRepository_hidDelWherecache identifier)- not affected, since excluded with
$ignore_arrayininitmethod
- not affected, since excluded with
Expected impact
Using PageRepository without taking these two additional aspects into account, it might happen that invoking PageRepository multiple times with different contexts (having different aspects for date and frontend.user) leads to unexpected results – basically, the first PageRepository invocation defined the where clause.
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.