TYPO3 Forger
  • Dashboard
  • Get involved
  • Reviews
    Overview Ready for review Work in progress Needs action Needs review Needs verification Needs rebase Negative votes Reviewed and verified Ready to merge
  • Issues
    Stale issues Possible duplicates By category By month
  • Sprints
    Overview Initiatives TYPO3 Core Review board
  • Tools
    Backports ReST helper
  • Help
  • Search
  • Login
Esc

Words find the open ones, a number the issue and the change with it.

  1. Issues
  2. #91509
Issue Task Closed

#91509Switch to json_encode for tx_cms_showpic parameters

Oliver Hader 05/27/20, 17:09 updated 12/22/20, 11:09

Open in Forge Comment in Forge

Description

Scalar values sent via HTTP query parameters to ShowImageController are using `json_encode` instead of `unserialize`. The parameter stream is still secured with an HMAC before being deserialized.

Reviews 3

  • 9.5 64609[TASK] Switch to json_encode for tx_cms_showpic parameters Resolves this issue Merged Oliver Hader CR +2 V +2 → main, 10.4 Easy +9 −4 05/30/20, 08:16
  • 10.4 64608[TASK] Switch to json_encode for tx_cms_showpic parameters Resolves this issue Merged Oliver Hader CR +2 V +2 → main, 9.5 Easy +9 −4 05/30/20, 08:16
  • main 64589[TASK] Switch to json_encode for tx_cms_showpic parameters Resolves this issue Merged Oliver Hader CR +2 V +2 → 10.4, 9.5 Easy +9 −4 05/30/20, 08:15

Related issues 1

  • Bug #91882ShowImageController throws PHP warning because of #91509 Related to Closed Miscellaneous v9 S P 07/29/20, 08:00
Assigned to
Oliver Hader
Author
Oliver Hader
Priority
Should have
Category
Security
TYPO3 version
9
Tags
hardening
© 2026 TYPO3 GmbH.
  • API
  • Privacy Policy
  • Legal Notice
  • Feedback