Issue Bug Rejected

#91774Site configuration base changes are not observed for page redirect source URLs

Oliver Eglseder 07/09/20, 14:59 updated 09/04/26, 05:29

Description

Setup:
  • Site with empty (“/”) base.
  • A page in the page tree within the site.
Steps to reproduce
  • Change the site base to a full qualified URL (like “https://example.com”)
  • Change the slug of a page in the page tree
What happens:
  • A redirect with the source_host of the current page will be created.
What should happen instead:
  • The source_host of the created redirect must be “*”, because the original URL of the page did not resolve to any specific domain.
Example:
  • Site with base “/” and page with slug “/foo” can be accessed with any domain and path /foo
  • After the site base changed the page can only be accessed with the new base. The new page url is “https://example.com/foo”
  • The redirect must therefore redirect from “http(s)://*/foo” to “https://example.com/foo”
  • BUT: The source_host of the generated redirect includes the new domain, which prevents redirects from matching any other previous host/domain.
Implications:
  • The generation of redirects has to check the last valid URL of the page before any change has been made to the page and its site.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.

History 1

  1. Georg Ringer commented and changed status New Rejected <span data-processor="relativetime" data-value="2026-09-04T05:29:00+00:00" > 09/04/26, 05:29 </span>

    Hey Oliver,

    checked the issue and I reject it as changing the site is up to the system maintainer who should know what he does. Having “/” as url is also not good and mentioned in the config.

    Additionally there is no concept of “a page knows its last valid site”.

    In the long run we should get rid of the domain in the redirect and use the site’s identifier but this is another issue and out of scope here.

    hope you understand