Issue Bug Closed

#92052Wrong return hint for TYPO3\CMS\Core\Domain\Repository\PageRepository::getRecordOverlay

Kevin Ditscheid 08/20/20, 10:31 updated 09/29/20, 15:06

Description

The return hint in the doc block states that it would return FALSE when there is no translation and the OLmode is set to “hideNonTranslated”.
The method is setting the row to NULL in those cases, thus not respecting the hint and misleading developers into assuming the wrong return values.
I think we should be clearer here, to avoid developers from checking for === FALSE or something similar, and mention the NULL instead of FALSE.

Reviews 2