Issue Bug Closed

#93449ContentObjectRenderer: Dbal compatible field quoting not working for 'leftjoin' and 'rightjoin' - only for 'join'

Ayke Halder 02/05/21, 17:44 updated 02/23/21, 13:05

Description

The Dbal compatible field quoting in ContentObjectRenderer is not working for leftjoin and rightjoin .

There is a uppercase typo in typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:
must be leftjoin/@rightjoin@, not leftJoin/@rightJoin@.

https://github.com/TYPO3-CMS/frontend/blob/2afb96c6725d7751bdb2ca3a53e9566b2eaff52b/Classes/ContentObject/ContentObjectRenderer.php#L5723-L5752

    public function getQuery($table, $conf, $returnQueryArray = false)
    {
[…]
        $properties = [
[…]
            'join',
            'leftjoin',
            'rightjoin',
[…]
        ];
        foreach ($properties as $property) {
[…]
            } elseif (in_array($property, ['languageField', 'selectFields', 'join', 'leftJoin', 'rightJoin', 'where'], true)) {
                $conf[$property] = QueryHelper::quoteDatabaseIdentifiers($connection, $conf[$property]);
            }

affected TYPO3 versions

  • master
  • 10.4
  • 9.5
  • 8.7

Documentation

Reviews 3