Issue Bug New Orphaned

#94039Change of the tt_content plugin can lead to corrupted FlexForm

Xavier Perseguers 05/03/21, 07:28 updated 05/03/21, 10:30

Description

One of my webmasters changed a EXT:news plugin to become a EXT:file_list plugin.

As usual, the former FlexForm is kept instead of being cleared and both FlexForm start being interleaved.

<?xml version="1.0" encoding="utf-8" standalone="yes" ?>
<T3FlexForms>
    <data>
        <sheet index="sDEF">
            <language index="lDEF">
                <field index="settings.mode">
                    <value index="vDEF">FOLDER</value>
                </field>
                <field index="settings.path">
                    <value index="vDEF"><![CDATA[t3://folder?storage=1&identifier=REMOVED]]></value>
                </field>
                <field index="settings.orderBy">
                    <value index="vDEF">NAME</value>
                </field>
                <field index="settings.sortDirection">
                    <value index="vDEF">ASC</value>
                </field>
                <field index="settings.includeSubfolders">
                    <value index="vDEF">0</value>
                </field>
                <field index="settings.orderDirection">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.dateField">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.categoryConjunction">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.categories">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.includeSubCategories">
                    <value index="vDEF">0</value>
                </field>
                <field index="settings.archiveRestriction">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.timeRestriction">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.timeRestrictionHigh">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.topNewsRestriction">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.singleNews">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.previewHiddenRecords">
                    <value index="vDEF">2</value>
                </field>
                <field index="settings.startingpoint">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.recursive">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.selectedList">
                    <value index="vDEF"></value>
                </field>
            </language>
        </sheet>
        <sheet index="display">
            <language index="lDEF">
                <field index="settings.newDuration">
                    <value index="vDEF">0</value>
                </field>
                <field index="settings.templateLayout">
                    <value index="vDEF">Simple</value>
                </field>
            </language>
        </sheet>
        <sheet index="additional">
            <language index="lDEF">
                <field index="settings.detailPid">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.listPid">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.backPid">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.limit">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.offset">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.tags">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.hidePagination">
                    <value index="vDEF">0</value>
                </field>
                <field index="settings.list.paginate.itemsPerPage">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.topNewsFirst">
                    <value index="vDEF">0</value>
                </field>
                <field index="settings.excludeAlreadyDisplayedNews">
                    <value index="vDEF">0</value>
                </field>
                <field index="settings.disableOverrideDemand">
                    <value index="vDEF">1</value>
                </field>
            </language>
        </sheet>
        <sheet index="template">
            <language index="lDEF">
                <field index="settings.media.maxWidth">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.media.maxHeight">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.cropMaxCharacters">
                    <value index="vDEF"></value>
                </field>
                <field index="settings.templateLayout">
                    <value index="vDEF"></value>
                </field>
            </language>
        </sheet>
    </data>
</T3FlexForms>

Problem is that EXT:file_list has settings.templateLayout as well, but not under the same “sheet”, EXT:news has it under sheet “display” whereas EXT:file_list has it under sheet “template”.

When my webmaster choose another template, the key from sheet “display” is updated, instead of the (correct) key under sheet “template”. This leads to the key being empty and the EXT:file_list plugin just cannot be properly updated.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.

Fix this issue

Start the commit message of your patch with this. Add what the patch does, and the versions it goes to in "Releases:". How to create a patch

Commit message
[BUGFIX] Change of the tt_content plugin can lead to corrupted FlexForm Resolves: #94039 Releases: main