#94162Update Slughelper to allow both dash and lodash Characters
Description
Hi there,
at the moment, the slughelper converts both dash and lodash to the fallback character -
typo3/sysext/core/Classes/DataHandling/SlugHelper.php:115
// Convert some special tokens (space, "_" and "-") to the space character
$fallbackCharacter = (string)($this->configuration['fallbackCharacter'] ?? '-');
$slug = preg_replace('/[ \t\x{00A0}\-+_]+/u', $fallbackCharacter, $slug);
Page title with - and _ xSince both Characters are valid for urls, it would be good if there would be at least the option to keep these characters,
so that the result would be
page-title-with-and-_-x
Reviews 2
Related issues 1
Files 2
History 1327
Show 2 earlier messages
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2021-07-08T15:01:18+00:00" > 07/08/21, 15:01 </span>
-
Christine Zoglmeier commented <span data-processor="relativetime" data-value="2021-08-12T10:30:24+00:00" > 08/12/21, 10:30 </span>
-
Stefan Bürk commented <span data-processor="relativetime" data-value="2021-08-12T11:19:41+00:00" > 08/12/21, 11:19 </span>
@Christine
Forget to note here … I worked on it to .. but as you wrote in general/general in discord, and I’m in remote sprint/general did not see it.
I’m ready to push a patch, done the work with tests .. wrote in discord.
Should i push mine ? or how should we solve this “double work conflict” ?
-
Christine Zoglmeier commented <span data-processor="relativetime" data-value="2021-08-12T11:34:02+00:00" > 08/12/21, 11:34 </span>
Go ahead and push yours. I will compare your solution with mine.
-
Gerrit Code Review pushed patch set 1 for master to change 70481 status
NewUnder Review <span data-processor="relativetime" data-value="2021-08-12T11:45:26+00:00" > 08/12/21, 11:45 </span> -
Gerrit Code Review pushed patch set 2 for master to change 70481 <span data-processor="relativetime" data-value="2021-08-12T13:38:07+00:00" > 08/12/21, 13:38 </span>
-
Gerrit Code Review pushed patch set 3 for master to change 70481 <span data-processor="relativetime" data-value="2021-08-12T20:20:37+00:00" > 08/12/21, 20:20 </span>
-
Gerrit Code Review pushed patch set 4 for master to change 70481 <span data-processor="relativetime" data-value="2021-08-14T10:05:42+00:00" > 08/14/21, 10:05 </span>
-
Gerrit Code Review pushed patch set 5 for master to change 70481 <span data-processor="relativetime" data-value="2021-08-19T16:47:51+00:00" > 08/19/21, 16:47 </span>
-
Gerrit Code Review pushed patch set 6 for master to change 70481 <span data-processor="relativetime" data-value="2021-08-23T17:09:16+00:00" > 08/23/21, 17:09 </span>
-
Gerrit Code Review pushed patch set 7 for master to change 70481 <span data-processor="relativetime" data-value="2021-08-24T20:31:44+00:00" > 08/24/21, 20:31 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2021-09-07T07:45:12+00:00" > 09/07/21, 07:45 </span>
-
Gerrit Code Review pushed patch set 8 for master to change 70481 <span data-processor="relativetime" data-value="2021-11-19T13:32:33+00:00" > 11/19/21, 13:32 </span>
-
Gerrit Code Review pushed patch set 9 for master to change 70481 <span data-processor="relativetime" data-value="2021-11-19T13:41:36+00:00" > 11/19/21, 13:41 </span>
-
Gerrit Code Review pushed patch set 10 for master to change 70481 <span data-processor="relativetime" data-value="2021-11-25T19:31:25+00:00" > 11/25/21, 19:31 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 70481 <span data-processor="relativetime" data-value="2021-11-29T14:10:47+00:00" > 11/29/21, 14:10 </span>
-
Oliver Hader changed Related to #94693 <span data-processor="relativetime" data-value="2021-12-01T13:48:50+00:00" > 12/01/21, 13:48 </span>
-
Eric Harrer commented and changed attached core-10.4.21.patch <span data-processor="relativetime" data-value="2021-12-06T15:11:54+00:00" > 12/06/21, 15:11 </span>
Is it possible to extend the official support for this feature to typo3 10 and 11?
Based on this patch, I created a patch file for TYPO3 version 10. Maybe it will be of use to someone.
-
Simon Gilli commented <span data-processor="relativetime" data-value="2021-12-06T16:05:19+00:00" > 12/06/21, 16:05 </span>
@eric as we are talking about a feature here the chances are really small to get the permission for a backport. The policy is clear, no features are backported normally.
-
Gerrit Code Review pushed patch set 12 for main to change 70481 <span data-processor="relativetime" data-value="2022-06-11T15:24:18+00:00" > 06/11/22, 15:24 </span>
-
Oliver Hader changed Sprint Focus On Location Sprint <span data-processor="relativetime" data-value="2022-11-03T13:43:09+00:00" > 11/03/22, 13:43 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2023-04-05T09:54:46+00:00" > 04/05/23, 09:54 </span>
-
Benni Mack changed Sprint Focus
On Location Sprint<span data-processor="relativetime" data-value="2023-08-02T13:05:21+00:00" > 08/02/23, 13:05 </span> -
Markus Timtner commented and changed attached core-11.5.41.patch <span data-processor="relativetime" data-value="2025-05-21T09:09:00+00:00" > 05/21/25, 09:09 </span>
Since I just found this isn’t available for v11, I created a patch for that, too.
-
Benni Mack commented and changed status
Under ReviewNew <span data-processor="relativetime" data-value="2026-03-16T16:40:07+00:00" > 03/16/26, 16:40 </span>Setting this to new, since Stefan set the patch as abandoned.
-
Gerrit Code Review pushed patch set 1 for main to change 97008 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-22T13:40:21+00:00" > 10/22/26, 13:40 </span> -
Gerrit Code Review pushed patch set 2 for main to change 97008 <span data-processor="relativetime" data-value="2026-11-20T15:25:29+00:00" > 11/20/26, 15:25 </span>
Working on it