#94683setPid on AbstractDomainObject should not force void return type
Description
I believe it is a good practice to have fluent setters (return type self) for instance in order to have immutable objects. Sure in that case it should be called with*. Nevertheless I don’t find it necessary to force void as a return type on AbstractDomainObject->setPid. Also this avoids clean code styles like:
$someService->save((new Entity())->setPid(123));
/**
* Setter for the pid.
*
* @param int $pid
*/
public function setPid(int $pid): void
{
$this->pid = $pid;
}
If TYPO3 does not use this i fully understand but at least it should not force void return type, which makes it impossible as an extension developer to have fluent setters apart from creating a different method like setPageUid().
Kind regards and thank you for the great work
Rozbeh Chiryai Sharahi
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
History 3
-
Rozbeh Chiryai Sharahi changed description 08/01/21, 16:21
-
Bastian Bringenberg commented and changed project id TYPO3 Version 10 08/01/21, 17:27
-
Georg Ringer commented and changed status
NewRejected 05/25/24, 15:01closing this issue as declaring the return type is always good and changing the return type is never a good thing.
as you already tell, there is always the option to use alternativ methods
Guessed TYPO3 Version.
Moved Project.