#96635Improve XML handling of XmlEncoder and XmlDecoder
Description
During the review phase of task #83580 these follow-up improvements of the XML handling came up:
1) Refactor $additionalOptions
Referring to: \TYPO3\CMS\Core\Encoder\XmlEncoder
Christian Kuhn: I still wonder if we need this huge confusing $additionalOptions implementation in our generic encoder / decoder implementation: afair, EXT:impexp is the only place that uses this huge bandwidth of things. Maybe we should have a generic implementation that is much more streamlined and easier, and EXT:impexp then has an own solution that does all the additional magic?
2) Make $options class member
Referring to: \TYPO3\CMS\Core\Encoder\XmlDecoder
Referring to: \TYPO3\CMS\Core\Encoder\XmlEncoder
Oliver Hader: I think $options should be a class member variable, defined in a constructor – this way passing options to internal methods can be avoided.
Alexander Nitsche: Yes, could be. Leaving it as method argument underlines the immutable character of this class though. Having no objections to change it, if still wanted.
3) Harden CDATA encoding
Referring to: \TYPO3\CMS\Core\Encoder\XmlEncoder::parseArray()
Oliver Hader: It should be ensured that $value does not contain any XML literals – currently it seems to be possible to leave the CDATA section and create a new node, e.g. with
$value = ']]><evil>whatever</evil><![CDATA['
In other words: $value needs to be handled as well for that scope.
Oliver Hader: This is how PHP would do it:
<?php
$dom = new \DOMDocument();
$node = $dom->createElement('data');
$dom->appendChild($node);
$cdata = $dom->createCDATASection(' x ]]><evil>whatever</evil><![CDATA[ x ');
$node->appendChild($cdata);
echo $dom->saveXML();
4) Improve binary data detection
Referring to: \TYPO3\CMS\Core\Encoder\XmlEncoder::isBinaryValue()
Oliver Harder: So basically control-chars (x00-x1f) without TAB, NL, CR: Seems x7f should be included as well (https://en.wikipedia.org/wiki/Control_character).
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
Related issues 1
History 2
-
Alexander Nitsche changed Related to #83580 <span data-processor="relativetime" data-value="2022-01-24T18:21:54+00:00" > 01/24/22, 18:21 </span>
-
Georg Ringer commented and changed status
NewClosed <span data-processor="relativetime" data-value="2026-09-29T18:00:32+00:00" > 09/29/26, 18:00 </span>
closing the issue.
as stated, still the case 1) is only used by impexp. 2+3 are solved and regarding 4
@isBinaryValue()@ detects 0×00–0×1F except tab, line feed and carriage return. 0×7F (DEL) is a valid character in XML 1.0 and is escaped correctly, so it does not need base64 encoding, even though it is formally a control character.