Issue Bug Closed

#96813BeforeRedirectEvent is not useful at all because it accepts no arguments and the return value is ignored

S P 02/10/22, 07:21 updated 07/09/24, 12:45

Description

Steps to reproduce:

  • Register your event class at the BeforeRedirectEvent
  • Let felogin trigger a redirect
  • the event gets fired
  • Problem: you have no way to do anything meaningful because the result value is not returned and no objects (e.g. the LoginConroller) are passed as argument.

The event gets the redirect URL and the login-type passed as parameter. But you neither can return a changed redirect URL nor change the calling controller (e.g. to inject another redirect URL).

The Event should provide at least one way to actually use the result from the event.

I flagged this as a bug, not as a feature, because the feature itself (the event) is already there, but it’s just dead code.

Reviews 2