Issue Bug Closed

#97226overrideFinishers form plugin can cause wrong formDefinitions

Yannis Viol 03/22/22, 14:03 updated 10/01/26, 16:43

Description

If a value is overriden via the overrideFinishers in the Plugin and is deleted afterwards it is still present as an empty value in the pi_flexform (in the Database). This does look like this then:

<field index="settings.finishers.EmailToSender.recipients">
   <el index="el"></el>
</field>

In that specific case the recipients being empty causes the form to not execute the MailFinisher properly and leading to an error.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.

Files 1

History 5

  1. Yannis Viol changed subject overrideFinishers from plugin can cause wrong formDefinitions overrideFinishers form plugin can cause wrong formDefinitions <span data-processor="relativetime" data-value="2022-03-22T14:03:19+00:00" > 03/22/22, 14:03 </span>

  2. Josua Vogel commented <span data-processor="relativetime" data-value="2026-10-01T14:29:26+00:00" > 10/01/26, 14:29 </span>

    Fixed by #103867, which describes the same behaviour: an emptied section
    override (e.g. recipients) in the form plugin’s finisher overrides replaced
    the value from the form definition with an empty value.

    Since the fix, FinisherOptionsFlexFormOverridesConverter skips empty
    section values, so the form definition’s recipients are kept.