Issue Story Closed

#97492Unnessesary SQL queries: PageRepository->getPage() with disableGroupAccessCheck=false/true

Christoph Lehmann 04/27/22, 16:57 updated 02/08/23, 16:05

Description

How to reproduce:

Place a sitemap menu element on your page. Visit that page in the frontend.

In the Admin panel you see 2 queries for every page in the menu.

(1) From PageRepository->getPage() with disableGroupAccessCheck=true

SELECT * FROM `pages` WHERE (`uid` = 79) AND (((`pages`.`deleted` = 0) AND (`pages`.`t3ver_state` <= 0) AND (`pages`.`t3ver_wsid` = 0) AND (`pages`.`t3ver_oid` = 0) AND (`pages`.`hidden` = 0) AND (`pages`.`starttime` <= 1651064700) AND ((`pages`.`endtime` = 0) OR (`pages`.`endtime` > 1651064700))) AND (`pages`.`doktype` <> 255))

(2) From PageRepository->getPage() with disableGroupAccessCheck=false

Same query in addition with

AND (((`pages`.`fe_group` = '') OR (`pages`.`fe_group` IS NULL) OR (`pages`.`fe_group` = '0') OR (FIND_IN_SET('0', `pages`.`fe_group`)) OR (FIND_IN_SET('-1', `pages`.`fe_group`))))

The function PageRepository->getPage() uses the runtime cache to reduce sql queries (good!). These two queries result in two cache keys.

The second query is only meaningful, when one uses frontend group restrictions.

A non-core solution to disable it is

# File: GetPageHook.php
<?php

namespace My\SiteExtension\Hooks;

use TYPO3\CMS\Core\Domain\Repository\PageRepository;
use TYPO3\CMS\Core\Domain\Repository\PageRepositoryGetPageHookInterface;
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;

class GetPageHook implements PageRepositoryGetPageHookInterface
{
    public function getPage_preProcess(&$uid, &$disableGroupAccessCheck, PageRepository $parentObject)
    {
        $disableGroupAccessCheck = true;
    }
}

---

# File: ext_localconf.php
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_page.php']['getPage'][] = \My\SiteExtension\Hooks\GetPageHook::class;

—-

A core solution that prevents the second query would be nice.

Reviews 4