#97754Refactoring: Add repository and data mapper for WorkspaceRecord/AbstractRecord
Description
In \TYPO3\CMS\Workspaces\Domain\Record\WorkspaceRecord::get(), there are two patterns hidden that want to be emerge:
public static function get($uid, array $record = null)
{
if (empty($uid)) {
$record = [];
} elseif (empty($record)) {
$record = static::fetch(‘sys_workspace’, $uid);
}
return new self($record);
}
We should refactor this to the following structures:
- (Abstract)DataMapper: has a method to convert an array (which can also be empty) of data to an AbstractRecord instance
- WorkpaceRecordMapper: extends DataMapper
- AbstractRecordRepository::getByUid: retrieves a record from the DB an creates a record model instance; uses the data mapper
- WorkspaceRecordRepository extends AbstractRecordRepository
We also should deprecate WorkspaceRecord::get() and adapt all callers to use the repository or data mapper.
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.