#98129Workspace pagination is broken
Description
The pagination of the Workspaces module does not work. Visually it always displays the first 30 elements. When looking at the response of the AJAX request, it appears that all elements are returned every time, no matter what value is passed in the start parameter.
The culprit is \TYPO3\CMS\Workspaces\Service\GridDataService::calculateStartWithCollections() which always returns “0”. This is due to line 699, a regression introduced by https://github.com/TYPO3/typo3/commit/7258b52477a3c9119a24af20c1513c111dac768f (how could it be merged?). The problem is that the test on line 699:
if (!isset($this->dataArray[$recordsCount])) {
will always fail because the keys of array $this->dataArray are not numerical. They are strings assembled in \TYPO3\CMS\Workspaces\Service\GridDataService::generateDataArray(), on line 194:
$versionArray['id'] = $table . ':' . $record['uid'];Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.