Issue Bug Closed

#98647translate viewhelper always shows default with extensionName and key/id

Gregor Hermens 10/18/22, 09:42 updated 07/09/24, 12:46

Description

When using the translate viewhelper with parameters extensionName, key/id and default, instead of the translation the default value is shown, ie:

{f:translate(key: 'someKey', extensionName: 'SomeExtensionName', default: 'defaultValue')}

Actual result: defaultValue

Expected result: translation of id ‘someKey’ in current language
Default should only be a fallback if id ‘someKey’ is not defined in current and default language.

In file EXT:cms-fluid/Classes/ViewHelpers/TranslateViewHelper.php line 159-171, extensionName and key/id are transformed to ‘LLL:EXT:’ syntax only if default is empty.

In line 174, $value is set to id because of the missing ‘LLL:’.

In line 175-179, $value is set to default.

Possible solution: Remove the check for empty default from line 159.

Reviews 1