Showing results 1276 to 1300 of 1561

Feature
New Orphaned Form Framework

#85378 EXT:form option for saving uploaded file as sys_file_reference

In #85216 we discovered two problems:
  • The description how to save an uploaded file as sys_file_reference is missing.
  • If the file field isn’t mandatory and therefore empty the insert query for the sys_file_reference table throws an exception.

For the second problem the suggestion was to use a custom SaveToDatabase finisher.

I think this whole thing should be easier, especially because there are only two fields that need to be configured for the sys_file_reference table. The configuration could look something like this:

finishers:
  -
    identifier: SaveToDatabase
    options:
      table: 'tx_myext_domain_model_mymodel'
      mode:  'insert'
      elements:
        logo:
          mapOnDatabaseColumn: 'logo'
          saveAsFileReference: true
          skipIfValueIsEmpty: true
The SaveToDatabaseFinisher needs to be extended to look for those options and:
  1. Automatically performing an insert query on the sys_file_reference table with tablenames = <options> and fieldname = <options></options></options>
  2. Skip both the setting of the field in <options> and the complete insert query for sys_file_reference</options>
Author Lidia Demin
Created 06/25/18, 11:15
Updated 06/19/24, 11:18
Bug
New Orphaned Localization TYPO3 CMS 12

#82314 Copying content to other language creates duplicates

Hi everyone,

we have a page (german) with two translations (dutch and one for austria).
The content for dutch is translated via translation wizard and mode ‘Translate’ to connect the content elements.

The editor now wants to copy german content via drag’n‘drop while holding ctrl to austria.

Results:
1. The content is created correctly within the translation for austria.
2. The dutch representation of the german content element is duplicated within the dutch translation.

Expectation:
Result 2 should not occure.

Note: Deleting the copied element for austria also removes the dutch duplicate.

Kind Regards,
Jonathan Kieling

Author Jonathan Kieling
Created 09/06/17, 11:42
Updated 06/16/24, 07:04
Bug
Accepted Orphaned Site Handling, Site Sets & Routing TYPO3 CMS 11

#103948 Route with multiple / at the beginning is allowed and leads to duplicate content

having a valid page https://domain.ddev.site/imprint is fine but IMHO https://domain.ddev.site////imprint should lead to page a not found error and not showing the imprint page?

the canonical is however fine and shows only one /

Author Georg Ringer
Created 05/29/24, 06:25
Updated 06/13/24, 11:02
Task
New Orphaned Content Security Policy TYPO3 CMS 12

#102262 Add CSP MutationMode::InheritStatic (or similar)

From https://review.typo3.org/c/Packages/TYPO3.CMS/+/80756/comments/83fac188_a7132447

> I would prefer we had some kind of “late static binding” extensions, that says: “whatever is changed on the ancestor sometime later, please inherit“
> Maybe that could be “InheritStatic”.
> Anyway I’m still fine with this patch as is.

Author Oliver Hader
Assigned to Oliver Hader
Created 10/26/23, 08:30
Updated 06/11/24, 16:34
Task
Accepted Orphaned Tests TYPO3 CMS 13

#104049 Collisions in PSR-4 namespaces for tests

During the refactoring of the ViewHelper Schema Generator, I noticed that there are PSR-4 namespace collisions in the “Tests” folders of the core extensions. This usually isn’t a problem if the classes are referenced by their correct namespace, but nontheless they are resolvable with another namespace. In that case, the file will be required twice, which leads to the following exception:

> Fatal error: Cannot declare class TYPO3Tests\FluidTest\ViewHelpers\AbstractEscapingBaseViewHelper, because the name is already in use in /var/www/html/typo3/typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Classes/ViewHelpers/AbstractEscapingBaseViewHelper.php on line 22

The class in question is resolvable with the following namespaces:

> TYPO3Tests\FluidTest\ViewHelpers\AbstractEscapingBaseViewHelper (the “correct” one)
> TYPO3\CMS\Fluid\Tests\Functional\Fixtures\Extensions\fluid_test\Classes\ViewHelpers\AbstractEscapingBaseViewHelper

The source of the problem are the PSR-4 declarations in the root composer.json:

    "autoload-dev": {
        "psr-4": {
            "TYPO3\\CMS\\Fluid\\Tests\\": "typo3/sysext/fluid/Tests/",
            "TYPO3Tests\\FluidTest\\": "typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Classes/",

We discussed this with Sebastian Bergmann of phpunit, and he suggested to get rid of the namespaces to the “Tests” folders altogether because they are not required for phpunit to find the tests. Only exception is if there are non-test classes in that folder (e. g. an abstract test class or a utility) that are used by other test classes. In that case, the individual file could be added to the classmap manually.

Author Simon Praetorius
Created 06/11/24, 12:05
Updated 06/11/24, 15:38
Task
Under Review Orphaned TYPO3 CMS 13

#104038 Typoscript cache can become quite large

In our setup the typoscript cache gets quite large. We’re seeing ~10MB cache size.
This is not a huge issue if you’re running a few sites, but we’re running a setup with ~3000 TYPO3 sites, having 10MB data that needs to be read for each site affects disk caching rates, which is untenable for us.

I’ve been examining the typoscript cache and it’s not that we’re really storing that much, it’s mostly that the design of the typoscript parser combined with the ineffeciencies of serialize, causes the file to explode in size. I’ve tried replacing it with igbinary_serialize and that cuts the size to ~1/8.
Ofcourse, adding a dependency on igbinary to TYPO3 is probably not a good decision, so that’s not the right fix.

However, Looking through the typoscript cache, I don’t really understand why it’s a code cache, it just defines a PHP file that returns the contents of the serialized objects, it doesn’t use any capability that shouldn’t work with a plain data cache.

I’ve created a patch for this and hope for some feedback.

Author Rasmus Sallling
Created 06/11/24, 08:14
Updated 06/11/24, 15:10
Bug
New Orphaned Backend User Interface TYPO3 CMS 12

#104019 The "Paste" button does not have adequate labeling.

To improve accessibility for screen reader users, the Paste button should be labeled similarly to the + Content button. See https://forge.typo3.org/issues/104018. The ID of the title and the Ctype are suitable for labeling.

Author Christian Rath-Ulrich
Created 06/10/24, 13:47
Updated 06/10/24, 13:47
Task
New Orphaned TypoScript TYPO3 CMS 13

#103882 unify additionalAttributes with includeCSS / includeJS

Currently the behaviour of #91499 is different depending on the variant of page.includeCSS* / includeJS* used.

See following table for an overview:

data.data-xxx / data.foo data-xxx / foo
——————— ————————————— ————————
CSS Exception +
CSSLibs Exception +
JS + –
JSFooter + –
JSLibs Exception +
JSFooterlibs Exception +

Exception means: array to string exception as there is a string expected when an array gets delivered
+: working
-: not working

When using page.includeJS / page.includeJSFooter you have to add additional attributes as data-array.
But when using includeCSS or one of the libs-variants you must not use data-array but deliver additional attributes as key-value pairs directly.

This issue is opened as FollowUp of #100954 which was already marked ad resolved.

Following ideas were already collected:
  • “quickfix” for v12 to use both variants data.foo and foo side by side in all cases
  • add a “new” param to includeCSS*/includeJS* -> additionalAttributes to overtake the functionality
  • mark data. and the plain usage of data-main deprecated in v13 and remove in v14
reasons for change from data. to additionalAttributes.:
  • it is not only about data-attributes
  • data in TypoScript is in some way related to getText
  • additionalAttributes is already used as wording in fluid for the same topic
reasons for change from key/value to additionalAttributes.:
  • separate parameters with defined functions from those with just free behaviour
  • easier to handle with specified array collecting all additional attributes, see includeJS/includeJSFooter in \TYPO3\CMS\Frontend\Http\RequestHandler
Author Markus Volkmer
Created 05/23/24, 07:45
Updated 06/10/24, 10:52
Feature
New Orphaned Dashboard

#90443 Idea for dashboard at initial installation of new TYPO3

It would be cool to add a new dashboard to the first user after a TYPO3 installation was successful.
That dashboard could carry all necessary information to get started. Would make also sense to make it the default module instead of the “About”.

That way new users that setup a TYPO3 installation get an “Introduction Dashboard” with all information to get deeper into the system.
Also static texts like “Next Steps” could be added.

That might improve the user experience for first time users.

Author Daniel Siepmann
Assigned to Richard Haeser
Created 02/19/20, 20:20
Updated 06/09/24, 18:39
Bug
Accepted Orphaned Backend JavaScript TYPO3 CMS 12

#103950 "Page enable" via page tree opens "view in frontend" in some cases

Steps to reproduce:

Login to https://demo.typo3.org/typo3

1. Open any Content element
2. Click the “View” button. (works fine)
3. Close the new tab to see the backend again.
4. Enable or Disable any page via Page tree context menu.

-> The action will be performed, but also the view action is replayed.

As far as I see this happens when the very last action was “Show view” from inside a content element. This happens NOT if you perform “Show view” from the page view (and have no content element open).

Author Marc Willmann
Created 05/29/24, 11:47
Updated 06/06/24, 18:37
Bug
Accepted Orphaned FormEngine aka TCEforms TYPO3 CMS 9

#92144 T3DataStructure with field pid will throw RuntimeException

<T3DataStructure>
 <meta type="array">
  <langDisable>1</langDisable>
 </meta>
 <sheets type="array">
      <sDEF1 type="array">
           <ROOT type="array">
            <TCEforms type="array">
                 <sheetTitle>LLL:EXT:xxx/locallang_flexform.xml:xxx.sheet_1</sheetTitle>
            </TCEforms>
            <type>array</type>
            <el>
            <pid>
                <TCEforms>
                        <label>LLL:EXT:xxx/locallang_flexform.xml:xxx.pid</label>
                        <config>
                            <type>group</type>    
                            <internal_type>db</internal_type>
                            <allowed>pages</allowed>
                            <minitems>1</minitems>
                            <maxitems>1</maxitems>
                        </config>
                    </TCEforms>
             </pid>
               </el>
           </ROOT>
      </sDEF1>
 </sheets>
</T3DataStructure>

will raise

(1/1) #1521220142 RuntimeException
inlineFirstPid should either be an integer or a "NEW..." string

in /var/www/typo3/public_html/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php line 118

same works in V7 oder with different a name (<pid> -&gt; <somename>)</somename></pid>

Author Marc Lindemann
Created 08/31/20, 17:44
Updated 05/27/24, 19:49
Bug
New Orphaned Authentication TYPO3 CMS 12

#103932 getRecoveryCodes mfa fallback provider is always loaded in Frontend mode

I’ve been looking into the performance of TYPO3v12 and spotted some behavior of the MFA logic that seems dubious.

The MFA logic seems to currently only be supported in Backend mode, but because the logic is implemented in AbstractUserAuthentication and not in BackendUserAuthentication.php, some of the MFA logic is actually run for both backend and frontend. The “checkAuthentication” function calls “evaluateMfaRequirements” in both frontend and backend.
Aside from probably being unnecessary at this point, it also has moderate response time consequences. ~11ms are used to load the RecoveryCodesProvider class for every single request in our setup, and I believe that is with completely default MFA settings. It looks like more or less all this time is spent in DependencyInjection. I’m not completely sure why this isn’t cached in the DI cache, but it doesn’t seem to be.

I would have sent a patch, but I’m unsure of how to approach this issue, I see a few options:

1: Only call “evaluateMfaRequirements” in the backend context. Since TYPO3 officially doesn’t support it in Frontend, this would seem reasonable, but I guess it could break some usage scenarios. Also silly, if there are features on the way to support it in frontend.
2: Add an option to disable it in frontend.
3: Change the dependency injection, so that the needed providers (RecoveryCodesProvider and others) are cached in the DI cache.

This seems to have been introduced in TYPO3v12 at some point.

Author Rasmus Sallling
Created 05/27/24, 07:20
Updated 05/27/24, 07:20
Feature
Under Review Orphaned TypoScript

#103860 Add Symfony expressions/condition to TypoScript if function

It should be possible to use Symfony expressions/condition in TypoScript if function.
This could make if function statements more easy to write (and understand).

Author Remo H.
Created 05/19/24, 17:42
Updated 05/22/24, 23:23
Bug
New Orphaned File Abstraction Layer (FAL) TYPO3 CMS 11

#103870 Element browser search respects only the first given filemount

When an editor uses the search field in the element browser, only the first filemount is respected:

After entering “Bild” as search query, there are only results from the first filemount:

Expected behaviour: the selected filemount or all filemounts should be respected in search.

Author Holger McCloy
Created 05/21/24, 14:16
Updated 05/21/24, 14:19
Bug
Under Review Orphaned Caching TYPO3 CMS 11

#100360 Cache is not invalidated for referenced content via "Insert Records" / Shortcut CE

Hi everyone,

we recently stumpled upon a very annoying issue, that got not noticed since some time (years, ever?!)
The page cache is not invalidated, if there are shortcut content elements and the referenced element got changes.

*Steps to reproduce:*
- Insert a common content element on “page 1“
- Insert a shortcut CE on “page 2” and select the recently added content elment from step 1 as reference
- open new Browser or Incognito Tab
- navigate to “page 1” and “page 2“
- (have look to database and verify, that both pages got cached)
- edit the original CE on Page 1
- reload “page 2” frontend in incognito Tab
- see, that nothing changed
- open “page 1” frontend in incognito Tab – on this page everything is fine, caches got invalidated

This is reproducable on v11 and v12.

This issue gets even more complicated, when one of the extensions Container, Gridelements or Flux are in place.
In this cases child records need to be observed for changes as well. Likly the parent elements get referenced.

Kind regards
Henrik

Author Henrik Ziegenhain
Created 03/30/23, 13:35
Updated 05/17/24, 22:07
Task
New Orphaned Backend API TYPO3 CMS 13

#103848 Refactoring of checks for record editable etc.

All those same checks for record editable etc. are implemented for 3 times:

  • TYPO3\CMS\Backend\View\BackendLayout\Grid\GridColumnItem
  • TYPO3\CMS\Backend\RecordList\DatabaseRecordList
  • TYPO3\CMS\Backend\ContextMenu\ItemProviders\RecordProvider

This needs some big refactoring.

Also see https://review.typo3.org/c/Packages/TYPO3.CMS/+/81616 which implements some changes in all these 3 places.

Author Ayke Halder
Created 05/16/24, 13:12
Updated 05/16/24, 13:12
Bug
New Orphaned Frontend TYPO3 CMS 13

#103800 Slide for CONTENT object does not work if last element is empty

If you are using a CONTENT object with the slide = -1 setting, it’s possible that the content of the current page and the content of the parent page are shown.

If the last element on the current page generates completly empty HTML, the if condition in ContentContentObject is wrong.

Steps to reproduce:

1. Install empty TYPO3
2. Create a root page with a text element
3. Create a subpage with a text element and an empty HTML element
4. Create TypoScript on the root page which includes fluid_styled_content and the following TypoScript

# Default PAGE object:
page = PAGE
page.10 = CONTENT
page.10.table = tt_content
page.10.slide = -1

tt_content.html >
tt_content.html = TEXT

5. Check the output of the subpage.

Result:

The element of the subpage and the element of the rootpage are shown

Expected Result:

Only the element of the subpage should be shown.

Bugfix

The bug is in this line:
https://github.com/TYPO3/typo3/blob/30399b0eb7d9b08b31f35e1e23cdcfb676ae6aff/typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php#L137

$tmpValue = $cObj->cObjGetSingle($renderObjName, $renderObjConf, $renderObjKey);
$cobjValue .= $tmpValue;
...
} while ($again && $slide && ((string)$tmpValue === '' && $slideCollectFuzzy || $slideCollect));

If the last cObj generates an empty string, tmpValue is empty and the while does not stop.
The while loop should check cobjValue.

The bug nearly exists since the beginning of Time ;-)
https://github.com/TYPO3/typo3/commit/dc716cca936f3749b0a1c381a1eb05e274b24c78
https://github.com/TYPO3/typo3/blob/dc716cca936f3749b0a1c381a1eb05e274b24c78/typo3/sysext/cms/tslib/class.tslib_content.php#L1196

Author Robert Vock
Created 05/07/24, 12:21
Updated 05/07/24, 12:21
Feature
New Orphaned File Abstraction Layer (FAL)

#90623 FAL: video thumbnails in BE module Filelist

The thumbnails of video files (eg: .mp4, .avi) are not displayed in the backend filelist module

Author Robert von Hackwitz
Created 03/03/20, 10:39
Updated 05/03/24, 18:08
Bug
New Orphaned Site Handling, Site Sets & Routing TYPO3 CMS 12

#90163 Site config still being used even if page is no longer site root

If the “Use as Root Page” flag is removed from the properties of a page with its own site config, that site config is still being used in the FE, if the config.yaml file is still present.

This can be highly misleading as the page is no longer visually recognizable as a site root in BE. Additionally, it shows up under “Unassigned site configurations” in sites management, with the explanation:

“The following sites don’t belong to any page anymore and can be removed.”

This also suggests that the site config is no longer in use, while it actually still is.

IMHO, this is actually a missing feature: an easy way to disable/enable a site configuration without having to rename/delete the respective config.yaml. I had hoped that this could be achieved by temporarily removing the “Use page as Root Page” flag.

Author Michael Stopp
Created 01/21/20, 11:32
Updated 05/01/24, 15:30
Feature
Under Review Orphaned Site Handling, Site Sets & Routing

#89518 Decouple static routes from site config

Regarding the restrictions of static routes, we tried to find a solution for all use cases but unfortunately this is not possible with the current architecture of static routes. The main design flaw is that static routes are bound to sites but sites do not have to be exclusive in terms of their base. This leads to an arbitrary static route resolving.

To circumvent the current restriction on site configurations that have no dedicated entry point “/” the only solution would be to consider rearranging the Middlewares in your installation.

Goal:

We need to decouple static routes from site configuration and treat them more like redirects are treated now. They need to be globally defined to remove the arbitrariness when resolving. In this case we could think about serving them in a dedicated sysext (like redirects) because then the functionality could be removed completely if not needed (to reduce bloat).

To keep static routes “deployable” they could live in a yaml file instead of the database and probably be editable through a dedicated backend module.

Author Daniel Goerz
Created 10/25/19, 18:37
Updated 04/22/24, 19:07
Task
New Orphaned TypoScript TYPO3 CMS 12

#103468 Verbose handling when @import 'EXT:site/Configuration/TypoScript/lib/*.typoscript' does not find a file

The TypoScript backend module has the nice output for syntax checker warnings:

These warnings should produce log messages.

Also “EXT:nonexistent/Configuration/TypoScript,” in include_static_file.txt could/should produce warnings.

Author Christoph Lehmann
Created 03/22/24, 10:35
Updated 04/22/24, 11:59
Bug
New Orphaned Backend User Interface TYPO3 CMS 12

#103534 UX: Backend Page Module - Content Elements drag-n-drop grab-area not visually distinguable

In Page Module for new editors the visual hint that Content Elements can be moved by drag-n-drop is missing.

Old TYPO3 v11 vs. new design proposal:

  • Above: old – gray bar is grab-area to move Content Element
  • Below: design proposal – thin line divides header-area which is grabbable from non-grabbable content-area

Actual implementation in TYPO3 v12

  • Above: as-is
  • Below: as-is – actual grabbable area highlighted (blue)

How to fix?

Any ideas on how to make the grabbable area visually distinguable?

Maybe add a button like for IRRE records – e.g. media assets?

Author Ayke Halder
Created 04/04/24, 16:06
Updated 04/18/24, 15:00
Task
Under Review Orphaned Code Cleanup TYPO3 CMS 10

#95722 Why does TYPO3 have a slug-helper?

Hello Community,

this is just to have a general understanding of a pattern on TYPO3 code, which I do not really understand.

Since TYPO3 9 we have inhouse pretty-urls. For this, as usual these days, we have fortunately slug fields on the entities. Thank you for all this.

TYPO3 is a very mature system and it is comprehensible that we have some legacy codes here and there that look weird from today’s perspective.

Now looking at the slug-helper I kind of get lost, why these kind of code-styles are still introduced on TYPO3. The slug-helper cannot be that old and at the same time TYPO3 is now enforcing dependency injection with non-public services. Therefore accessing containers and GeneralUtility::makeInstance is advised not to be done.

Well with a Helper like this it will be quite hard to obey these conventions:

$slugHelper = GeneralUtility::makeInstance(
    SlugHelper::class,
    $tableName,
    $slugFieldName,
    $fieldConfig
);

$slugHelper->generate($hereSomeArray, int $pid);
...

This way constructor injection is very hard up to not possible imho. Also it is not very intuitive to use. Why do we introduce a slug-helper in this pattern?

Imo the right way to do this would be for instance something like this:

$slugService = new SlugService();
$slugService->getGenerator($table, $fieldName)->generateByUid(int $uid)
// or
$slugService->generate($table, $fieldname, $uid)
// or 
$slugService->generate(SlugGenerateConfigurationObject)
// or
...

This is just one of many possible patterns, nevertheless this way we could

- use enforced constructor injection
- dismiss usage of general utitlity
- write tests easily by simple injection instead of registering instances on containers, …
- understand usage simply by auto-complete

I have that feeling, that there should be some code patterns which are enforced on TYPO3 Core Code. I have this feeling, that in 5 years there will be a strong dependency on this slug-helper and there will be soon a lot of work to deprecate them.

Nevertheless I don’t see exactly what kind of recommended common pattern the current implementation is following.

Please correct me with literature if I am wrong and this pattern has some advantages.

Thank you for all your great work.

Kind regards
Rozbeh Chiryai Sharahi

Author Rozbeh Chiryai Sharahi
Created 10/21/21, 13:59
Updated 04/17/24, 22:39
Bug
New Orphaned DataHandler aka TCEmain TYPO3 CMS 11

#97526 Page properties with no l10n_mode are empty after translation

Upon translating a page, properties (e.g. categories, rowDescription) with missing l10n_mode are not copied to the translation as stated in the l10n_mode documantion.

https://docs.typo3.org/m/typo3/reference-tca/main/en-us/Columns/Properties/L10nMode.html

If this property is not set for a given field, the value of the default language record is copied over to the localized record on creation, the field value is then distinct from the default language record, can be edited at will and will never be overwritten by the DataHandler if the value of the default language record changes.

Instead the fields are empty (in DB its NULL). However, configuring the exact same fields in some custom table, they behave just fine as expected. I suspect that the distinction between pages and other tables in the DataHandler is causing the problem:

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4749

Here, for pages an empty new record is created while applying the $overrideValues which do not include the field values for fields without l10n_mode. For other tables a regular copyRecord is perfomed that copies the whole default language record (including field without l10n_mode) while appling the $overrideValues afterwards.

Why is this?

Note: This is also true for TYPO3 10.4

Reproduce:

  1. Setup a project with two languages
  2. Create and translate a category
  3. Create a page in default language setting values for (categories, rowDescription, description)
  4. Translate the page

Expected behavior:

  1. categories (no l10n_mode) —> translation should have the same categories selected as the default language record
  2. rowDescripton (no l10n_mode) —> translation should have the same value as the default language record
  3. description (l10n_mode: prefixLangTitle) —> translation should have the same value as the default language record with some prefix

Actual behavior:

  1. categories (no l10n_mode) —> empty
  2. rowDescrpiton (no l10n_mode) —> empty
  3. description (l10n_mode: prefixLangTitle) —> same value as the default language record with some prefix
Author Martin Schulz
Created 05/02/22, 08:40
Updated 04/17/24, 10:11
Bug
New Orphaned Backend User Interface TYPO3 CMS 12

#103585 History of content element does not show image deletions

Steps to reproduce

  • Create a content element with an image
  • Delete the image from the content element
  • Inspect the history of this content element

=> no mention of deleted image

Expected behaviour

The history of the CE should show that an update has occurred, which removed some image or media.

Current workaroud for a restore

Use the history of the containing page, which will list the deletion of the `sys_file_reference` record.

Author Markus Klein
Created 04/10/24, 08:39
Updated 04/10/24, 08:39

Showing results 1276 to 1300 of 1561