Review main Merged

1804[CLEANUP] Fix TCA tree the same as in TYPO3_4-5

Helmut Hummel CR +2 V +2 Easy +4 −3 updated 06/03/13, 20:49

Commit message

The TCA tree feature did not work when setting maxitems=1 in the TCA.

This bug has been fixed in master in 290529a75647fe2bf6847638763e50348631e906 and in
TYPO3_4-5 branch 3019ca92f55faf650ad5981a001e323a2e91eab6 but the solution is different.

Use the same solution as is TYPO3_4-5 because it is cleaner:

* Check for empty() value instead of comparing with 0 in 
  t3lib/tceforms/class.t3lib_tceforms_tree.php
* Do not recalculate the number of checked items only if a new
  item is checked and the maximum item count is reached instead of always
  recalculating the item count in 
  t3lib/js/extjs/tree/tree.js

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2