Issue Bug Closed

#25347TCA type "select", renderMode "tree", maxitems = 1 doesn't work

Marco Huber 03/16/11, 16:53 updated 05/26/11, 22:13

Description

I want to use the new TCA tree, but when I configure 1 as maxitems I can’t select a tree node.

This happens, because this.countSelectedNodes in t3lib\js\extjs\tree\tree.js is 1 even when I create a new record. And this.countSelectedNodes is 1 because $valueArray in t3lib\tceforms\class.t3lib_tceforms_tree.php in the function renderField always has at least one entry.

$valueArray is created by exploding $PA[‘itemFormElValue’]. In fresh records $PA[‘itemFormElValue’] is 0 and not NULL (or not set) and has no other effects. But $valueArray has an entry and that’s why count($valueArray) is 1 and then this.countSelectedNodes is also 1.

To fix this issue $PA[‘itemFormElValue’] should be only exploded when it’s not 0. Like I worte, this is done in t3lib\tceforms\class.t3lib_tceforms_tree.php and fixed in the appended patch.

Fixing this issue causes a little follow up in t3lib\js\extjs\tree\tree.js. This is also fixed in the patch.

I hope the patch file’s syntax is correct, this is my first git patch ;-)

(issue imported from #M17976)

Reviews 2