Review main Merged

31730[CLEANUP] SqlParser

Andreas Kienast CR +2 V +2 Normal +83 −58 updated 09/05/18, 18:49

Commit message

Introduce a few optimizations in
the SqlParser classes of "core" and "dbal".

* Change some regular expressions (see benchmark file in forge)
* Strict comparison
* Put often used variable manipulation into a new method
* Definition of $comparatorPatterns was in a while() without any
  modification on it, so make it a protected member

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3