Issue Task Closed

#60479Micro optimizations in SqlParser

Andreas Fernandez 07/22/14, 22:21 updated 10/02/18, 11:52

Description

Introduced a few optimizations in the SqlParser classes of “core” and “dbal”. I had the problem that many queries (e.g. updating the extension list) takes a lot more time when using dbal and adodb (oci8 driver in this case) so I tried to get a few microseconds.

Optimizations made:
  • Changed some regular expressions (see attached benchmark file)
  • Strict comparison
  • Put often used variable manipulation into a new method
  • Definition of $comparatorPatterns was in a while() without any modification on it, so made it a protected member

Reviews 1