Review main Merged

43736[BUGFIX] RadioViewHelper correct property checked mapping

Andreas Allacher CR +2 V +2 Easy +1 −0 updated 10/21/15, 21:02

Commit message

AbstractEntity objects are not correctly mapped as checked.
Previously the checked comparison failed because the value
attribute was converted to the identifier but not the property value.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Morton Jonuschat +1
  • Verified V +2
    • Stefan Neufeind +2
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 7

  1. Andreas Allacher uploaded patch set 1 10/02/15, 10:18

  2. Oliver Hader uploaded patch set 2 10/09/15, 00:10

  3. Morton Jonuschat voted on patch set 2 CR +1 V +1 10/16/15, 14:51

  4. Stefan Neufeind commented on patch set 2 10/18/15, 16:13

    @Claus: I guess we might need to keep this in sync with "upstream-Fluid"?
  5. Claus Due commented on patch set 2 10/18/15, 16:36

    @Stefan That depends on what you consider the upstream Fluid at this point. If we talk about standalone Fluid then no, nothing is necessary - it doesn't contain any of the Form ViewHelpers. If you talk about the Flow Fluid then yes, this would introduce a difference from that to CMS Fluid, but in this case we don't really keep those in sync (do we?). Finally, if you talk about the CMS adapter package that's being reviewed right now then no, nothing required - once this is merged that patch just needs a rebasing to assimilate these changes.
  6. Stefan Neufeind voted on patch set 2 CR +2 V +2 10/20/15, 22:35

  7. Stefan Neufeind merged patch set 2 10/21/15, 21:02