Review main Abandoned

55508[BUGFIX] Respect language when fetch previous created language record

Armin Vieweg CR 0 V 0 Expert +1112 −927 updated 10/25/19, 17:53

Commit message

The "getPreviousLocalizedRecordUid()" method in DataHandler, got
parameter for language to translate to, but it assumed that source
language is always default (hardcoded 0).

This can break sorting of generated language records, because it
uses wrong records to calculate the sorting, when translating from
a foreign language.

This patch adds a new parameter to this method, to pass and respect
the source language.

Now the "localizeContentFromNonDefaultLanguage" tests will fail when
source language is not respected.

Added third translated record to function test data set, to be able to
reproduce calculation issue. Also fixed a bug in LiveDefaultElements
data set, regarding sortings.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 122

Show 102 more files