Review main Merged

57941[TASK] Deprecate PageGenerator class

Benni Mack CR +2 V +2 Expert +1003 −89 updated 08/17/18, 10:37

Commit message

The static class PageGenerator is a list of
static methods previouly found in "pagegen.php", which
has now been moved within the RequestHandler which
is now fully responsible for turning a request object
with support from TSFE and PageRenderer into a response object.

This removes one further dependency built around a
legacy class and enjoys the concept that RequestHandler+TSFE
now share the responsibility for building $TSFE->content.

This also means that all tests can now be built without
having to use any global variables or some special Singleton
functionality but with a clean structure in mind.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 8