61213[BUGFIX] Improve performance for unique slug detection
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1114
-
Thomas Fischer uploaded patch set 1 07/02/19, 15:47
-
TYPO3com voted on patch set 1 V -1 07/02/19, 15:47 Completed build in 13s on Tue, 2 Jul, 05:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34713
-
Oliver Klee commented on patch set 1 07/02/19, 15:57
SlugHelper.php:700This is almost the same code as the code a few lines above. Please let's move it to a method to reduce code duplication. -
Thomas Fischer uploaded patch set 2 07/03/19, 11:53
-
TYPO3com voted on patch set 2 V -1 07/03/19, 11:53 Completed build in 12s on Wed, 3 Jul, 01:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34729
-
Thomas Fischer commented on patch set 2 07/03/19, 11:57
> Patch Set 1: > > (2 comments) Tried to improve this with patch set 2, including some more refactoring.SlugHelper.php:299ReplyDoneSlugHelper.php:700ReplyDone -
Thomas Fischer uploaded patch set 3 07/03/19, 12:54
-
Thomas Fischer wrote 07/03/19, 12:57
Description set to "Code style and annotation fixes" -
TYPO3com voted on patch set 3 V -1 07/03/19, 13:05 Completed build in 11m 31s on Wed, 3 Jul, 03:05 PM Test Summary: 12 of 47203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34734
-
Thomas Fischer marked it work in progress 07/03/19, 22:33
-
Sybille Peters commented on patch set 3 11/22/21, 07:13
Hi, this is set to "Work in Progress". Are you still working on it? -
Benni Mack wrote 11/29/21, 10:21
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 4 11/29/21, 14:10
-
Benni Mack abandoned the change 10/15/24, 10:05
Hey Thomas, I will abandon this change due to lack of feedback now. Feel free to repush this change once you get back to it.
SlugHelper.php:299