Review main Abandoned

61213[BUGFIX] Improve performance for unique slug detection

Thomas Fischer CR 0 V 0 Normal +180 −32 updated 10/15/24, 10:05

Commit message

First collect all record ids below the root page the current record
belongs to and then compare only their slugs against that of the
current record. This avoids repeating expensive calls to
matchByPageId() and getRootPageId() in SiteMatcher/Site.

Adds usage of the runtime cache for data that is queried
recursively from inside and outside the class, especially from
DataHandler->fixUniqueInSiteForSubpages().

Has better performance in large installations with a lot of
identical slugs within different sites.

Performance yet to be evaluated on large installations with fewer sites
and very deeply nested page trees.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1114

  1. Thomas Fischer uploaded patch set 1 07/02/19, 15:47

  2. TYPO3com voted on patch set 1 V -1 07/02/19, 15:47 Completed build in 13s on Tue, 2 Jul, 05:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34713

  3. Oliver Klee commented on patch set 1 07/02/19, 15:57

    SlugHelper.php:299

    This method is getting bigger and bigger. Can we please some self-contained parts of it to a well-named method (i.e., the "extract method" refactoring)?

    SlugHelper.php:700

    This is almost the same code as the code a few lines above. Please let's move it to a method to reduce code duplication.
  4. Thomas Fischer uploaded patch set 2 07/03/19, 11:53

  5. TYPO3com voted on patch set 2 V -1 07/03/19, 11:53 Completed build in 12s on Wed, 3 Jul, 01:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34729

  6. Thomas Fischer commented on patch set 2 07/03/19, 11:57

    > Patch Set 1: > > (2 comments) Tried to improve this with patch set 2, including some more refactoring.

    SlugHelper.php:299 Reply

    Done

    SlugHelper.php:700 Reply

    Done
  7. Thomas Fischer uploaded patch set 3 07/03/19, 12:54

  8. Thomas Fischer wrote 07/03/19, 12:57

    Description set to "Code style and annotation fixes"
  9. TYPO3com voted on patch set 3 V -1 07/03/19, 13:05 Completed build in 11m 31s on Wed, 3 Jul, 03:05 PM Test Summary: 12 of 47203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34734

  10. Thomas Fischer marked it work in progress 07/03/19, 22:33

  11. Sybille Peters commented on patch set 3 11/22/21, 07:13

    Hi, this is set to "Work in Progress". Are you still working on it?
  12. Benni Mack wrote 11/29/21, 10:21

    Change destination moved from master to main
  13. Benni Mack updated the commit message in patch set 4 11/29/21, 14:10

  14. Benni Mack abandoned the change 10/15/24, 10:05

    Hey Thomas, I will abandon this change due to lack of feedback now. Feel free to repush this change once you get back to it.