Issue Bug New Orphaned Regression Good first issue

#88672SlugHelper->isUniqueInSite() slow for installations with many sites and similar URL structures

Thomas Fischer 07/02/19, 14:13 updated 10/15/24, 10:05

Description

If a large installation has a lot of sites / root pages, each with similar or identical page structures of a few levels, calling fixUniqueInSite() and especially fixUniqueInSiteForSubpages() in the DataHandler becomes slow due to the way potentially duplicate URLs are retrieved in SlugHelper->isUniqueInSite().

A fix could include a different or two alternative approaches for duplicate URL retrieval, taking into account the size and the overall page structure of the installation.

Also, the runtime cache could be used inside isUniqueInSite(), as this method is called recursively from inside fixUniqueInSiteForSubpages() and some of the necessary data (e.g. site definitions, root page association of a single page) should not be changed from the outside inbetween these calls.

Reviews 1

Fix this issue

Start the commit message of your patch with this. Add what the patch does, and the versions it goes to in "Releases:". The changes above were merged or abandoned: read them before you start. How to create a patch

Commit message
[BUGFIX] SlugHelper->isUniqueInSite() slow for installations with many sites and similar URL structures Resolves: #88672 Releases: main