Review main Abandoned

61521[WIP][TASK] Unify handling of errorParams in linkvalidator

Sybille Peters CR 0 V 0 Normal +123 −89 updated 02/16/20, 08:01

Commit message

* protected parameter errorParams was unnecessarily redefined
  in ExternalLinktype class (already introduced in parent
  class AbstractLinkType)
* errorType had inconsistent type (string and int), now use
  string
* initializing of errorParams is done consistently
  in AbstractLinkType
* usage of errorParams is now done consistently in various
  Linktype checker classes
* the error message is now only constructed once
  when generating the report

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8