Issue Task Closed

#88991Unify handling of errorParams in linkvalidator

Sybille Peters 08/21/19, 14:37 updated 01/01/22, 11:32

Description

  • protected parameter errorParams is unnecessarily redefined in ExternalLinktype class (already introduced in parent class AbstractLinkType)
  • initializing of errorParams done differently in each class, can be done in one way in AbstractLinkType
  • usage of errorParams is done differently in various Linktype checker classes
  • the error message is constructed twice, once when it is written into tx_linkvalidator_link.url_reponse and again when it is read from the database for the report
  • only the errorParams[‘errorMessage’] needs to be stored in the database, not the rest This is actually not a good idea because error message should be localized when report is generated

Reviews 1