Review main Ready for review Orphaned

66052[BUGFIX] Handle fallback when default language of a site is not uid=0

Xavier Perseguers CR 0 V -1 Easy +5 −0 updated 04/22/26, 13:05

Commit message

In case of a multi-site install with various default language to be
semantically considered, the default language of a site may not always
have sys_language_uid=0 but should still be able to support fallback
if needed.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/66052/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/66052/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 1

Issues 1

Files 1

Review log 1215

  1. Xavier Perseguers uploaded patch set 1 10/06/20, 07:15

  2. TYPO3com voted on patch set 1 V -1 10/06/20, 07:15 Completed build in 22s on Tue, 6 Oct, 07:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6258

  3. Xavier Perseguers commented on patch set 1 10/08/20, 14:54

    This part basically works but I found another limitation with the list of available languages when editing a record in such a context. Currently unsure if related to languages defined for a site (but logically it should be) and, if so, unsure if that other fix should logically belong to this patch as well.
  4. Benni Mack commented on patch set 1 11/10/21, 11:52

    Hey Xavier, which would be the other change you mentioned?
  5. Benni Mack updated the commit message in patch set 2 11/18/21, 10:46

  6. Benni Mack wrote 11/29/21, 10:16

    Change destination moved from master to main
  7. Benni Mack updated the commit message in patch set 3 11/29/21, 14:02

  8. Xavier Perseguers commented on patch set 3 01/12/22, 13:59

    Reply

    Hey Benni, Just had a look at my own currently applied patch in production and after all I didn't extended more.
  9. Benni Mack updated the commit message in patch set 4 05/03/23, 09:14

  10. Oliver Hader rebased onto patch set 5 05/03/23, 11:45

  11. core-ci voted on patch set 5 V -1 05/03/23, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41514

  12. Benni Mack updated the commit message in patch set 6 V -1 10/18/24, 14:07

  13. Benni Mack wrote 04/21/26, 14:55

    Removed cc Benni Mack.
  14. Benni Mack updated the commit message in patch set 7 04/22/26, 06:48

  15. core-ci voted on patch set 7 V -1 04/22/26, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100804