67642[BUGFIX] Proper honeypot validation if no session data exists
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 10
- Build/phpstan/phpstan-baseline.neon+35 −0
- typo3/sysext/form/Classes/Core/FormRequestHandler.php+11 −0
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime/HoneypotHandler.php3new+253 −0
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php4+78 −118
- typo3/sysext/form/Classes/Middleware/HoneypotRegistry.phpnew+95 −0
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+19 −0
- typo3/sysext/form/Configuration/RequestMiddlewares.phpnew+16 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/AbstractRequestHandlingTest.php+14 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+63 −48
- typo3/sysext/form/Tests/Unit/Domain/Runtime/FormRuntime/HoneypotHandlerTest.phpnew+328 −0
Review log 64108
Show 4983 earlier messages
-
Ralf Zimmermann uploaded patch set 1 02/04/21, 13:47
-
TYPO3com voted on patch set 1 V +1 02/04/21, 13:57 Completed build in 09m 43s on Thu, 4 Feb, 01:57 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9261
-
Ralf Zimmermann commented on patch set 2 02/05/21, 11:21
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 02/05/21, 11:30 Completed build in 09m 04s on Fri, 5 Feb, 11:30 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9292
-
Ralf Zimmermann updated the commit message in patch set 3 02/05/21, 18:25
-
TYPO3com voted on patch set 3 V +1 02/05/21, 18:33 Completed build in 07m 58s on Fri, 5 Feb, 06:33 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9315
-
Ralf Zimmermann uploaded patch set 4 02/06/21, 07:47
-
core-ci voted on patch set 4 V +1 02/06/21, 07:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/435
-
TYPO3com voted on patch set 4 V +1 02/06/21, 07:59 Completed build in 11m 44s on Sat, 6 Feb, 07:59 AM Test Summary: 32610 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9319
-
Ralf Zimmermann updated the commit message in patch set 5 02/06/21, 09:10
-
Ralf Zimmermann commented on patch set 6 02/06/21, 09:12
Published edit on patch set 5. -
TYPO3com voted on patch set 5 V +1 02/06/21, 09:19 Completed build in 09m 08s on Sat, 6 Feb, 09:19 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9320
-
TYPO3com voted on patch set 6 V +1 02/06/21, 09:28 Completed build in 12m 58s on Sat, 6 Feb, 09:28 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9321
-
Ralf Zimmermann uploaded patch set 7 02/06/21, 11:21
-
TYPO3com voted on patch set 7 V -1 02/06/21, 11:31 Completed build in 09m 38s on Sat, 6 Feb, 11:31 AM Test Summary: 2 of 32852 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9322
-
core-ci voted on patch set 5 V +1 02/06/21, 18:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/436
-
core-ci voted on patch set 6 V +1 02/06/21, 18:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/437
-
core-ci commented on patch set 7 02/06/21, 18:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/438
-
Timo Webler uploaded patch set 8 04/09/21, 09:11
-
TYPO3com voted on patch set 8 V -1 04/09/21, 09:11 Completed build in 16s on Fri, 9 Apr, 09:11 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10569
-
core-ci voted on patch set 8 V -1 04/09/21, 09:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2133
-
Timo Webler commented on patch set 8 04/09/21, 09:13
Only rebase of change to current master -
Timo Webler uploaded patch set 9 04/09/21, 09:16
-
TYPO3com voted on patch set 9 V +1 04/09/21, 09:24 Completed build in 07m 32s on Fri, 9 Apr, 09:24 AM Test Summary: 33293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10570
-
core-ci voted on patch set 9 V +1 04/09/21, 09:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2134
-
Oliver Hader uploaded patch set 10 05/03/21, 19:48
-
Oliver Hader commented on patch set 10 V -1 05/03/21, 19:50
Got some strange error during testing - will have a look again later/tomorrow: ``` Argument 1 passed to TYPO3\CMS\Form\Domain\Runtime\FormRuntime\HoneypotHandler::TYPO3\CMS\Form\Domain\Runtime\FormRuntime\{closure}() must be an instance of TYPO3\CMS\Form\Domain\Model\FormElements\AbstractFormElement, instance of TYPO3\CMS\Form\Domain\Model\FormElements\GridRow given ``` -
core-ci voted on patch set 10 V +1 05/03/21, 19:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11069
-
Oliver Hader uploaded patch set 11 05/03/21, 20:00
-
Oliver Hader rebased onto patch set 12 05/03/21, 20:03
-
Oliver Hader commented on patch set 12 05/03/21, 20:03
This change is ready for review. -
Oliver Hader commented on patch set 12 05/03/21, 20:04
Type error is solved now - will put more time into testing... -
core-ci voted on patch set 11 V +1 05/03/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11072
-
core-ci voted on patch set 12 V +1 05/03/21, 20:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11074
-
Jonas Eberle uploaded patch set 13 06/16/21, 17:30
-
Jonas Eberle commented on patch set 13 06/16/21, 17:38
Reply
Donerebased and brought in line with changes from https://review.typo3.org/c/Packages/TYPO3.CMS/+/69462 Not sure if I went too far with the typed members in FormRuntime. -
core-ci voted on patch set 13 V -1 06/16/21, 17:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12506
-
Jonas Eberle commented on patch set 13 06/16/21, 18:00
HoneypotHandler.php:119UnresolvedThe CI errors on this line. Sorry, I can't tell if that is related to the conflict merge I did. -
waldhacker uploaded patch set 14 08/11/21, 06:41
-
core-ci voted on patch set 14 V -1 08/11/21, 06:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14532
-
waldhacker uploaded patch set 15 08/11/21, 06:58
-
core-ci voted on patch set 15 V -1 08/11/21, 07:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14537
-
waldhacker uploaded patch set 16 08/11/21, 07:13
-
core-ci voted on patch set 16 V -1 08/11/21, 07:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14539
-
Björn Jacob updated the commit message in patch set 17 08/11/21, 07:34
-
waldhacker uploaded patch set 18 08/11/21, 07:49
-
core-ci voted on patch set 17 V -1 08/11/21, 07:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14542
-
core-ci voted on patch set 18 V -1 08/11/21, 08:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14544
-
waldhacker updated the commit message in patch set 19 08/11/21, 08:27
-
core-ci voted on patch set 19 V -1 08/11/21, 08:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14556
-
Björn Jacob commented on patch set 19 08/11/21, 09:01
Just some remarks/ nitpicks.FormRuntime.php:372Do we have to resolve the "ToDo" with this patch?FormRuntime.php:380Nitpick: it is always just one honey pot. IMHO, it should read as follows: "a new honey pot on each request"HoneypotHandler.php:40Nitpick: is "IDENTIFIER_ALPHABET" the "best" fitting name? What about something like "IDENTIFIER_ALLOWED_CHARS" or ""IDENTIFIER_ALLOWED_CHARACTERS"? -
waldhacker uploaded patch set 20 08/11/21, 09:05
-
Timo Webler wrote 08/11/21, 09:13
Removed reviewer Timo Webler. -
waldhacker uploaded patch set 21 08/11/21, 09:14
-
waldhacker commented on patch set 21 08/11/21, 09:15
FormRuntime.php:372ReplyYes i'll take care of it. $this->isAfterLastPage() is the same as $this->currentPage === nullFormRuntime.php:380ReplyAckHoneypotHandler.php:40ReplyAck -
core-ci voted on patch set 20 V +1 08/11/21, 09:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14558
-
core-ci voted on patch set 21 V +1 08/11/21, 09:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14560
-
Björn Jacob commented on patch set 21 V +1 CR +1 08/11/21, 10:24
Awesome. Works like a charm. -
waldhacker updated the commit message in patch set 22 08/11/21, 11:39
-
core-ci voted on patch set 22 V +1 08/11/21, 11:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14577
-
Björn Jacob voted on patch set 22 V +1 CR +1 08/11/21, 12:08
-
waldhacker rebased onto patch set 23 08/11/21, 13:44
-
core-ci voted on patch set 23 V +1 08/11/21, 13:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14593
-
Björn Jacob voted on patch set 23 V +1 CR +1 08/11/21, 14:23
-
Andreas Steiger commented on patch set 23 V +1 CR +1 08/11/21, 15:02
Nice! -
waldhacker voted on patch set 23 CR -1 08/11/21, 16:26
-
waldhacker commented on patch set 23 08/12/21, 00:10
Have to wait until https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460 is fixed. The caching determination can then be removed here. -
waldhacker uploaded patch set 24 08/12/21, 15:07
-
waldhacker voted on patch set 24 CR -1 08/12/21, 15:22
-
core-ci voted on patch set 24 V +1 08/12/21, 15:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14775
-
waldhacker rebased onto patch set 25 08/12/21, 23:09
-
core-ci voted on patch set 25 V +1 08/12/21, 23:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14871
-
waldhacker voted on patch set 25 CR -1 08/13/21, 09:47
-
waldhacker uploaded patch set 26 08/13/21, 18:00
-
waldhacker commented on patch set 27 08/13/21, 18:02
Published edit on patch set 26. -
waldhacker uploaded patch set 28 08/13/21, 18:07
-
core-ci voted on patch set 26 V -1 08/13/21, 18:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15011
-
core-ci voted on patch set 27 V -1 08/13/21, 18:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15012
-
core-ci voted on patch set 28 V -1 08/13/21, 18:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15014
-
waldhacker voted on patch set 28 CR -1 08/13/21, 18:30
-
waldhacker uploaded patch set 29 08/14/21, 13:06
-
waldhacker uploaded patch set 30 08/14/21, 13:09
-
waldhacker uploaded patch set 31 08/14/21, 13:13
-
core-ci voted on patch set 29 V +1 08/14/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15075
-
core-ci voted on patch set 30 V +1 08/14/21, 13:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15077
-
core-ci voted on patch set 31 V +1 08/14/21, 13:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15080
-
waldhacker rebased onto patch set 32 08/14/21, 15:57
-
waldhacker updated the commit message in patch set 33 08/14/21, 16:03
-
core-ci voted on patch set 32 V +1 08/14/21, 16:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15092
-
core-ci voted on patch set 33 V +1 08/14/21, 16:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15095
-
waldhacker voted on patch set 33 CR -1 08/30/21, 08:29
-
Andreas Häfner voted on patch set 33 V +1 CR +1 09/03/21, 10:27
-
waldhacker commented on patch set 33 09/03/21, 10:30
Unresolved
The middleware still needs to be adapted, as recommended here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67656/comment/fb01260c_aaa95189/ -
Benni Mack wrote 11/29/21, 10:09
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 34 11/29/21, 13:26
-
core-ci voted on patch set 34 V +1 11/29/21, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20027
-
waldhacker marked it work in progress 02/23/22, 08:18
-
waldhacker uploaded patch set 35 07/09/22, 16:20
-
waldhacker marked it ready for review 07/09/22, 16:21
-
waldhacker marked it work in progress 07/09/22, 16:26
-
core-ci voted on patch set 35 V -1 07/09/22, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28820
-
waldhacker uploaded patch set 36 07/10/22, 10:42
-
core-ci voted on patch set 36 V -1 07/10/22, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28848
-
waldhacker uploaded patch set 37 07/10/22, 11:52
-
core-ci voted on patch set 37 V +1 07/10/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28851
-
Simon Schaufelberger rebased onto patch set 38 08/03/22, 20:57
-
core-ci voted on patch set 38 V +1 08/03/22, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29804
-
Benni Mack abandoned the change 10/15/24, 10:06
Hey Ralf, I will abandon this change due to lack of activity now. Feel free to repush this change once you get back to it.