Review main Abandoned

67642[BUGFIX] Proper honeypot validation if no session data exists

Ralf Zimmermann CR 0 V 0 Expert +912 −166 updated 10/15/24, 10:06

Commit message

The honeypot protection has been improved massively. With this
patch the validation fails if no session data exists
and generally works on cached unsubmitted form pages.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 64108

Show 4983 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 02/04/21, 13:47

  2. TYPO3com voted on patch set 1 V +1 02/04/21, 13:57 Completed build in 09m 43s on Thu, 4 Feb, 01:57 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9261

  3. Ralf Zimmermann commented on patch set 2 02/05/21, 11:21

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 02/05/21, 11:30 Completed build in 09m 04s on Fri, 5 Feb, 11:30 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9292

  5. Ralf Zimmermann updated the commit message in patch set 3 02/05/21, 18:25

  6. TYPO3com voted on patch set 3 V +1 02/05/21, 18:33 Completed build in 07m 58s on Fri, 5 Feb, 06:33 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9315

  7. Ralf Zimmermann uploaded patch set 4 02/06/21, 07:47

  8. core-ci voted on patch set 4 V +1 02/06/21, 07:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/435

  9. TYPO3com voted on patch set 4 V +1 02/06/21, 07:59 Completed build in 11m 44s on Sat, 6 Feb, 07:59 AM Test Summary: 32610 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9319

  10. Ralf Zimmermann updated the commit message in patch set 5 02/06/21, 09:10

  11. Ralf Zimmermann commented on patch set 6 02/06/21, 09:12

    Published edit on patch set 5.
  12. TYPO3com voted on patch set 5 V +1 02/06/21, 09:19 Completed build in 09m 08s on Sat, 6 Feb, 09:19 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9320

  13. TYPO3com voted on patch set 6 V +1 02/06/21, 09:28 Completed build in 12m 58s on Sat, 6 Feb, 09:28 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9321

  14. Ralf Zimmermann uploaded patch set 7 02/06/21, 11:21

  15. TYPO3com voted on patch set 7 V -1 02/06/21, 11:31 Completed build in 09m 38s on Sat, 6 Feb, 11:31 AM Test Summary: 2 of 32852 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9322

  16. core-ci voted on patch set 5 V +1 02/06/21, 18:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/436

  17. core-ci voted on patch set 6 V +1 02/06/21, 18:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/437

  18. core-ci commented on patch set 7 02/06/21, 18:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/438

  19. Timo Webler uploaded patch set 8 04/09/21, 09:11

  20. TYPO3com voted on patch set 8 V -1 04/09/21, 09:11 Completed build in 16s on Fri, 9 Apr, 09:11 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10569

  21. core-ci voted on patch set 8 V -1 04/09/21, 09:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2133

  22. Timo Webler commented on patch set 8 04/09/21, 09:13

    Only rebase of change to current master
  23. Timo Webler uploaded patch set 9 04/09/21, 09:16

  24. TYPO3com voted on patch set 9 V +1 04/09/21, 09:24 Completed build in 07m 32s on Fri, 9 Apr, 09:24 AM Test Summary: 33293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10570

  25. core-ci voted on patch set 9 V +1 04/09/21, 09:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2134

  26. Oliver Hader uploaded patch set 10 05/03/21, 19:48

  27. Oliver Hader commented on patch set 10 V -1 05/03/21, 19:50

    Got some strange error during testing - will have a look again later/tomorrow: ``` Argument 1 passed to TYPO3\CMS\Form\Domain\Runtime\FormRuntime\HoneypotHandler::TYPO3\CMS\Form\Domain\Runtime\FormRuntime\{closure}() must be an instance of TYPO3\CMS\Form\Domain\Model\FormElements\AbstractFormElement, instance of TYPO3\CMS\Form\Domain\Model\FormElements\GridRow given ```
  28. core-ci voted on patch set 10 V +1 05/03/21, 19:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11069

  29. Oliver Hader uploaded patch set 11 05/03/21, 20:00

  30. Oliver Hader rebased onto patch set 12 05/03/21, 20:03

  31. Oliver Hader commented on patch set 12 05/03/21, 20:03

    This change is ready for review.
  32. Oliver Hader commented on patch set 12 05/03/21, 20:04

    Type error is solved now - will put more time into testing...
  33. core-ci voted on patch set 11 V +1 05/03/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11072

  34. core-ci voted on patch set 12 V +1 05/03/21, 20:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11074

  35. Jonas Eberle uploaded patch set 13 06/16/21, 17:30

  36. Jonas Eberle commented on patch set 13 06/16/21, 17:38

    Reply

    Done
    rebased and brought in line with changes from https://review.typo3.org/c/Packages/TYPO3.CMS/+/69462 Not sure if I went too far with the typed members in FormRuntime.
  37. core-ci voted on patch set 13 V -1 06/16/21, 17:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12506

  38. Jonas Eberle commented on patch set 13 06/16/21, 18:00

    HoneypotHandler.php:119 Unresolved

    The CI errors on this line. Sorry, I can't tell if that is related to the conflict merge I did.
  39. waldhacker uploaded patch set 14 08/11/21, 06:41

  40. core-ci voted on patch set 14 V -1 08/11/21, 06:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14532

  41. waldhacker uploaded patch set 15 08/11/21, 06:58

  42. core-ci voted on patch set 15 V -1 08/11/21, 07:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14537

  43. waldhacker uploaded patch set 16 08/11/21, 07:13

  44. core-ci voted on patch set 16 V -1 08/11/21, 07:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14539

  45. Björn Jacob updated the commit message in patch set 17 08/11/21, 07:34

  46. waldhacker uploaded patch set 18 08/11/21, 07:49

  47. core-ci voted on patch set 17 V -1 08/11/21, 07:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14542

  48. core-ci voted on patch set 18 V -1 08/11/21, 08:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14544

  49. waldhacker updated the commit message in patch set 19 08/11/21, 08:27

  50. core-ci voted on patch set 19 V -1 08/11/21, 08:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14556

  51. Björn Jacob commented on patch set 19 08/11/21, 09:01

    Just some remarks/ nitpicks.

    FormRuntime.php:372

    Do we have to resolve the "ToDo" with this patch?

    FormRuntime.php:380

    Nitpick: it is always just one honey pot. IMHO, it should read as follows: "a new honey pot on each request"

    HoneypotHandler.php:40

    Nitpick: is "IDENTIFIER_ALPHABET" the "best" fitting name? What about something like "IDENTIFIER_ALLOWED_CHARS" or ""IDENTIFIER_ALLOWED_CHARACTERS"?
  52. waldhacker uploaded patch set 20 08/11/21, 09:05

  53. Timo Webler wrote 08/11/21, 09:13

    Removed reviewer Timo Webler.
  54. waldhacker uploaded patch set 21 08/11/21, 09:14

  55. waldhacker commented on patch set 21 08/11/21, 09:15

    FormRuntime.php:372 Reply

    Yes i'll take care of it. $this->isAfterLastPage() is the same as $this->currentPage === null

    FormRuntime.php:380 Reply

    Ack

    HoneypotHandler.php:40 Reply

    Ack
  56. core-ci voted on patch set 20 V +1 08/11/21, 09:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14558

  57. core-ci voted on patch set 21 V +1 08/11/21, 09:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14560

  58. Björn Jacob commented on patch set 21 V +1 CR +1 08/11/21, 10:24

    Awesome. Works like a charm.
  59. waldhacker updated the commit message in patch set 22 08/11/21, 11:39

  60. core-ci voted on patch set 22 V +1 08/11/21, 11:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14577

  61. Björn Jacob voted on patch set 22 V +1 CR +1 08/11/21, 12:08

  62. waldhacker rebased onto patch set 23 08/11/21, 13:44

  63. core-ci voted on patch set 23 V +1 08/11/21, 13:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14593

  64. Björn Jacob voted on patch set 23 V +1 CR +1 08/11/21, 14:23

  65. Andreas Steiger commented on patch set 23 V +1 CR +1 08/11/21, 15:02

    Nice!
  66. waldhacker voted on patch set 23 CR -1 08/11/21, 16:26

  67. waldhacker commented on patch set 23 08/12/21, 00:10

    Have to wait until https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460 is fixed. The caching determination can then be removed here.
  68. waldhacker uploaded patch set 24 08/12/21, 15:07

  69. waldhacker voted on patch set 24 CR -1 08/12/21, 15:22

  70. core-ci voted on patch set 24 V +1 08/12/21, 15:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14775

  71. waldhacker rebased onto patch set 25 08/12/21, 23:09

  72. core-ci voted on patch set 25 V +1 08/12/21, 23:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14871

  73. waldhacker voted on patch set 25 CR -1 08/13/21, 09:47

  74. waldhacker uploaded patch set 26 08/13/21, 18:00

  75. waldhacker commented on patch set 27 08/13/21, 18:02

    Published edit on patch set 26.
  76. waldhacker uploaded patch set 28 08/13/21, 18:07

  77. core-ci voted on patch set 26 V -1 08/13/21, 18:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15011

  78. core-ci voted on patch set 27 V -1 08/13/21, 18:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15012

  79. core-ci voted on patch set 28 V -1 08/13/21, 18:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15014

  80. waldhacker voted on patch set 28 CR -1 08/13/21, 18:30

  81. waldhacker uploaded patch set 29 08/14/21, 13:06

  82. waldhacker uploaded patch set 30 08/14/21, 13:09

  83. waldhacker uploaded patch set 31 08/14/21, 13:13

  1. core-ci voted on patch set 29 V +1 08/14/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15075

  2. core-ci voted on patch set 30 V +1 08/14/21, 13:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15077

  3. core-ci voted on patch set 31 V +1 08/14/21, 13:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15080

  4. waldhacker rebased onto patch set 32 08/14/21, 15:57

  5. waldhacker updated the commit message in patch set 33 08/14/21, 16:03

  6. core-ci voted on patch set 32 V +1 08/14/21, 16:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15092

  7. core-ci voted on patch set 33 V +1 08/14/21, 16:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15095

  8. waldhacker voted on patch set 33 CR -1 08/30/21, 08:29

  9. Andreas Häfner voted on patch set 33 V +1 CR +1 09/03/21, 10:27

  10. waldhacker commented on patch set 33 09/03/21, 10:30

    Unresolved

    The middleware still needs to be adapted, as recommended here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67656/comment/fb01260c_aaa95189/
  11. Benni Mack wrote 11/29/21, 10:09

    Change destination moved from master to main
  12. Benni Mack updated the commit message in patch set 34 11/29/21, 13:26

  13. core-ci voted on patch set 34 V +1 11/29/21, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20027

  14. waldhacker marked it work in progress 02/23/22, 08:18

  15. waldhacker uploaded patch set 35 07/09/22, 16:20

  16. waldhacker marked it ready for review 07/09/22, 16:21

  17. waldhacker marked it work in progress 07/09/22, 16:26

  18. core-ci voted on patch set 35 V -1 07/09/22, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28820

  19. waldhacker uploaded patch set 36 07/10/22, 10:42

  20. core-ci voted on patch set 36 V -1 07/10/22, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28848

  21. waldhacker uploaded patch set 37 07/10/22, 11:52

  22. core-ci voted on patch set 37 V +1 07/10/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28851

  23. Simon Schaufelberger rebased onto patch set 38 08/03/22, 20:57

  24. core-ci voted on patch set 38 V +1 08/03/22, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29804

  25. Benni Mack abandoned the change 10/15/24, 10:06

    Hey Ralf, I will abandon this change due to lack of activity now. Feel free to repush this change once you get back to it.