#93435Honeypot validation fails if no session data exists
Description
At the moment the honeypot protection does not do anything if no session data exists .
The honeypot validation must fail if no session data exists.
Reviews 7
- 14.3 96768[BUGFIX] Keep the honeypot name in the form state
- main 80379[BUGFIX] Keep the honeypot name in the form state
- main 67642[BUGFIX] Proper honeypot validation if no session data exists
- 10.4 67643[BUGFIX] Proper honeypot validation if no session data exists
- 9.5 67644[BUGFIX] Proper honeypot validation if no session data exists
- main 67637[BUGFIX] Keep session object in sync with session storage values
- TYPO3_8-7 67645[BUGFIX] Proper honeypot validation if no session data exists
Related issues 4
History 1476
Show 551 earlier messages
-
Gerrit Code Review pushed patch set 1 for master to change 67642 status
NewUnder Review <span data-processor="relativetime" data-value="2021-02-04T13:48:03+00:00" > 02/04/21, 13:48 </span> -
Gerrit Code Review pushed patch set 1 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-02-04T13:50:37+00:00" > 02/04/21, 13:50 </span>
-
Gerrit Code Review pushed patch set 1 for 9.5 to change 67644 <span data-processor="relativetime" data-value="2021-02-04T13:53:04+00:00" > 02/04/21, 13:53 </span>
-
Gerrit Code Review pushed patch set 1 for TYPO3_8-7 to change 67645 <span data-processor="relativetime" data-value="2021-02-04T13:55:48+00:00" > 02/04/21, 13:55 </span>
-
Ralf Zimmermann commented <span data-processor="relativetime" data-value="2021-02-04T13:59:48+00:00" > 02/04/21, 13:59 </span>
-
Ralf Zimmermann changed description <span data-processor="relativetime" data-value="2021-02-04T16:24:56+00:00" > 02/04/21, 16:24 </span>
-
Gerrit Code Review pushed patch set 2 for master to change 67642 <span data-processor="relativetime" data-value="2021-02-05T11:21:20+00:00" > 02/05/21, 11:21 </span>
-
Gerrit Code Review pushed patch set 2 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-02-05T11:23:19+00:00" > 02/05/21, 11:23 </span>
-
Gerrit Code Review pushed patch set 2 for 9.5 to change 67644 <span data-processor="relativetime" data-value="2021-02-05T11:24:02+00:00" > 02/05/21, 11:24 </span>
-
Gerrit Code Review pushed patch set 2 for TYPO3_8-7 to change 67645 <span data-processor="relativetime" data-value="2021-02-05T11:24:51+00:00" > 02/05/21, 11:24 </span>
-
Gerrit Code Review pushed patch set 3 for master to change 67642 <span data-processor="relativetime" data-value="2021-02-05T18:25:11+00:00" > 02/05/21, 18:25 </span>
-
Gerrit Code Review pushed patch set 4 for master to change 67642 <span data-processor="relativetime" data-value="2021-02-06T07:48:08+00:00" > 02/06/21, 07:48 </span>
-
Gerrit Code Review pushed patch set 3 for 9.5 to change 67644 <span data-processor="relativetime" data-value="2021-02-06T07:48:15+00:00" > 02/06/21, 07:48 </span>
-
Gerrit Code Review pushed patch set 3 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-02-06T07:48:35+00:00" > 02/06/21, 07:48 </span>
-
Gerrit Code Review pushed patch set 4 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-02-06T07:55:27+00:00" > 02/06/21, 07:55 </span>
-
Gerrit Code Review pushed patch set 4 for 9.5 to change 67644 <span data-processor="relativetime" data-value="2021-02-06T08:01:13+00:00" > 02/06/21, 08:01 </span>
-
Gerrit Code Review pushed patch set 5 for master to change 67642 <span data-processor="relativetime" data-value="2021-02-06T09:10:25+00:00" > 02/06/21, 09:10 </span>
-
Gerrit Code Review pushed patch set 5 for 9.5 to change 67644 <span data-processor="relativetime" data-value="2021-02-06T09:10:31+00:00" > 02/06/21, 09:10 </span>
-
Gerrit Code Review pushed patch set 5 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-02-06T09:11:07+00:00" > 02/06/21, 09:11 </span>
-
Gerrit Code Review pushed patch set 6 for master to change 67642 <span data-processor="relativetime" data-value="2021-02-06T09:12:56+00:00" > 02/06/21, 09:12 </span>
-
Gerrit Code Review pushed patch set 6 for 9.5 to change 67644 <span data-processor="relativetime" data-value="2021-02-06T09:13:07+00:00" > 02/06/21, 09:13 </span>
-
Gerrit Code Review pushed patch set 6 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-02-06T09:13:17+00:00" > 02/06/21, 09:13 </span>
-
Gerrit Code Review pushed patch set 7 for master to change 67642 <span data-processor="relativetime" data-value="2021-02-06T11:21:53+00:00" > 02/06/21, 11:21 </span>
-
Gerrit Code Review pushed patch set 8 for master to change 67642 <span data-processor="relativetime" data-value="2021-04-09T09:11:35+00:00" > 04/09/21, 09:11 </span>
-
Gerrit Code Review pushed patch set 9 for master to change 67642 <span data-processor="relativetime" data-value="2021-04-09T09:16:34+00:00" > 04/09/21, 09:16 </span>
-
Gerrit Code Review pushed patch set 7 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-04-09T09:31:19+00:00" > 04/09/21, 09:31 </span>
-
Gerrit Code Review pushed patch set 10 for master to change 67642 <span data-processor="relativetime" data-value="2021-05-03T19:48:11+00:00" > 05/03/21, 19:48 </span>
-
Gerrit Code Review pushed patch set 11 for master to change 67642 <span data-processor="relativetime" data-value="2021-05-03T20:00:35+00:00" > 05/03/21, 20:00 </span>
-
Gerrit Code Review pushed patch set 12 for master to change 67642 <span data-processor="relativetime" data-value="2021-05-03T20:03:13+00:00" > 05/03/21, 20:03 </span>
-
Gerrit Code Review pushed patch set 13 for master to change 67642 <span data-processor="relativetime" data-value="2021-06-16T17:30:53+00:00" > 06/16/21, 17:30 </span>
-
Björn Jacob changed Sprint Focus Remote Sprint <span data-processor="relativetime" data-value="2021-08-06T11:57:31+00:00" > 08/06/21, 11:57 </span>
-
Björn Jacob changed Related to #93212 <span data-processor="relativetime" data-value="2021-08-06T11:59:34+00:00" > 08/06/21, 11:59 </span>
-
Björn Jacob changed Related to #93217 <span data-processor="relativetime" data-value="2021-08-06T11:59:47+00:00" > 08/06/21, 11:59 </span>
-
Gerrit Code Review pushed patch set 14 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T06:42:01+00:00" > 08/11/21, 06:42 </span>
-
Gerrit Code Review pushed patch set 15 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T06:58:34+00:00" > 08/11/21, 06:58 </span>
-
Gerrit Code Review pushed patch set 16 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T07:13:56+00:00" > 08/11/21, 07:13 </span>
-
Gerrit Code Review pushed patch set 17 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T07:34:45+00:00" > 08/11/21, 07:34 </span>
-
Gerrit Code Review pushed patch set 18 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T07:49:38+00:00" > 08/11/21, 07:49 </span>
-
Gerrit Code Review pushed patch set 19 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T08:27:50+00:00" > 08/11/21, 08:27 </span>
-
Gerrit Code Review pushed patch set 20 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T09:05:12+00:00" > 08/11/21, 09:05 </span>
-
Gerrit Code Review pushed patch set 21 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T09:14:50+00:00" > 08/11/21, 09:14 </span>
-
Gerrit Code Review pushed patch set 22 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T11:39:37+00:00" > 08/11/21, 11:39 </span>
-
Gerrit Code Review pushed patch set 8 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-08-11T11:41:48+00:00" > 08/11/21, 11:41 </span>
-
Gerrit Code Review pushed patch set 23 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-11T13:44:15+00:00" > 08/11/21, 13:44 </span>
-
Gerrit Code Review pushed patch set 24 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-12T15:07:18+00:00" > 08/12/21, 15:07 </span>
-
Gerrit Code Review pushed patch set 9 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-08-12T18:40:34+00:00" > 08/12/21, 18:40 </span>
-
Gerrit Code Review pushed patch set 25 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-12T23:09:27+00:00" > 08/12/21, 23:09 </span>
-
Gerrit Code Review pushed patch set 10 for 10.4 to change 67643 <span data-processor="relativetime" data-value="2021-08-12T23:09:41+00:00" > 08/12/21, 23:09 </span>
-
Gerrit Code Review pushed patch set 26 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-13T18:01:01+00:00" > 08/13/21, 18:01 </span>
-
Gerrit Code Review pushed patch set 27 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-13T18:02:34+00:00" > 08/13/21, 18:02 </span>
-
Gerrit Code Review pushed patch set 28 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-13T18:07:10+00:00" > 08/13/21, 18:07 </span>
-
Gerrit Code Review pushed patch set 29 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-14T13:06:12+00:00" > 08/14/21, 13:06 </span>
-
Gerrit Code Review pushed patch set 30 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-14T13:09:24+00:00" > 08/14/21, 13:09 </span>
-
Gerrit Code Review pushed patch set 31 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-14T13:13:59+00:00" > 08/14/21, 13:13 </span>
-
Gerrit Code Review pushed patch set 32 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-14T15:58:01+00:00" > 08/14/21, 15:58 </span>
-
Gerrit Code Review pushed patch set 33 for master to change 67642 <span data-processor="relativetime" data-value="2021-08-14T16:03:36+00:00" > 08/14/21, 16:03 </span>
-
Tim Spiekerkötter commented <span data-processor="relativetime" data-value="2021-08-23T13:57:16+00:00" > 08/23/21, 13:57 </span>
Hi Ralf, hi everyone else,
this looks promising. I was just about to open a new issue but I think this is what I found right now.
If I get this right, then currently the honeypot does not work at all, after the page was rendered once, right? I tried a fresh TYPO3 10 installation with nothing else installed, I created a form and put it on a page. After opening the page once TYPO3 creates an entry inside the cache_pages table where the honeypot field with it’s “unique” name is already generated. With the next page load the already build form is rendered directly from the cache and no cookie is set, so the validation doesn’t get added. Is there something we can do with TYPO3 10, 9 or even 8 (we are on ELTS here :() to get the honeypot to work?
Thank you for your work and cheers,
Diego -
Gerrit Code Review pushed patch set 34 for main to change 67642 <span data-processor="relativetime" data-value="2021-11-29T13:26:39+00:00" > 11/29/21, 13:26 </span>
-
András Ottó commented <span data-processor="relativetime" data-value="2021-12-08T11:47:49+00:00" > 12/08/21, 11:47 </span>
For anyone facing this issue.
Putting this line in a custom extion’s ext_localconf.php could work as a workout:
$GLOBALS[‘TYPO3_CONF_VARS’][‘EXTCONF’][‘extbase’][‘extensions’][‘Form’][‘plugins’][‘Formframework’][‘controllers’][\TYPO3\CMS\Form\Controller\FormFrontendController::class][‘nonCacheableActions’] = [0 => ‘render’, 1 => ‘perform’];
Basically we need to disable the cache for the renderAction otherwise the honeypot does not work.
-
Gerrit Code Review pushed patch set 35 for main to change 67642 <span data-processor="relativetime" data-value="2022-07-09T16:21:05+00:00" > 07/09/22, 16:21 </span>
-
Gerrit Code Review pushed patch set 36 for main to change 67642 <span data-processor="relativetime" data-value="2022-07-10T10:42:41+00:00" > 07/10/22, 10:42 </span>
-
Gerrit Code Review pushed patch set 37 for main to change 67642 <span data-processor="relativetime" data-value="2022-07-10T11:52:25+00:00" > 07/10/22, 11:52 </span>
-
Gerrit Code Review pushed patch set 38 for main to change 67642 <span data-processor="relativetime" data-value="2022-08-03T20:57:18+00:00" > 08/03/22, 20:57 </span>
-
Oliver Hader changed Related to #98084 <span data-processor="relativetime" data-value="2022-09-12T07:59:53+00:00" > 09/12/22, 07:59 </span>
-
Tim Schreiner changed Related to #101562 <span data-processor="relativetime" data-value="2023-08-03T19:57:46+00:00" > 08/03/23, 19:57 </span>
-
Tim Schreiner changed
Related to #101562<span data-processor="relativetime" data-value="2023-08-03T19:58:48+00:00" > 08/03/23, 19:58 </span> -
Tim Schreiner changed Duplicated by #101562 <span data-processor="relativetime" data-value="2023-08-03T19:59:02+00:00" > 08/03/23, 19:59 </span>
-
Oliver Hader changed Related to #103481 <span data-processor="relativetime" data-value="2024-04-29T08:12:24+00:00" > 04/29/24, 08:12 </span>
-
Benni Mack changed status
Under ReviewNew <span data-processor="relativetime" data-value="2024-10-15T10:06:35+00:00" > 10/15/24, 10:06 </span> -
Gerrit Code Review pushed patch set 9 for main to change 80379 status
NewUnder Review <span data-processor="relativetime" data-value="2026-03-06T12:29:36+00:00" > 03/06/26, 12:29 </span> -
Gerrit Code Review pushed patch set 10 for main to change 80379 <span data-processor="relativetime" data-value="2026-04-22T06:41:49+00:00" > 04/22/26, 06:41 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 80379 <span data-processor="relativetime" data-value="2026-09-28T21:09:34+00:00" > 09/28/26, 21:09 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 80379 <span data-processor="relativetime" data-value="2026-09-28T21:25:44+00:00" > 09/28/26, 21:25 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 80379 <span data-processor="relativetime" data-value="2026-10-15T21:44:27+00:00" > 10/15/26, 21:44 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 96768 <span data-processor="relativetime" data-value="2026-10-16T17:48:45+00:00" > 10/16/26, 17:48 </span>
-
Tim Schreiner commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-16T17:50:15+00:00" > 10/16/26, 17:50 </span>Applied in changeset commit:130f7d61cd1a945526282d3bdd3bf2fcfa8df46b.
Note that this patch can not be tested for TYPO3 v11 until this #93421 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/67637) is fixed.
Without https://review.typo3.org/c/Packages/TYPO3.CMS/+/67637 the honeypot feature does not work in any way in TYPO3 v11.