Review 10.4 Merged

68639[BUGFIX] Fix value of multiple select choices in site configuration

Richard Haeser CR +2 V +2 Easy +7 −1 updated 03/29/21, 13:15

Commit message

When extending the site configuration with an extension and
use a select box with multiple choices (selectSingleBox, selectCheckBox,
selectMultipleSideBySide), the activated options are stored
as an array in the config.yaml file. But to show the activated
items in the form again correctly they must be stored as in
comma-separated list.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Richard Haeser commented on patch set 1 03/29/21, 12:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/29/21, 12:43 Completed build in 07m 53s on Mon, 29 Mar, 12:43 PM Test Summary: 75936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1277

  3. core-ci voted on patch set 1 V +1 03/29/21, 13:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1896

  4. Richard Haeser voted on patch set 1 V +2 CR +2 03/29/21, 13:15

  5. Richard Haeser merged patch set 2 03/29/21, 13:15