Review 10.4 Merged

68733[TASK] Replace Mock with real instance in ReferrerEnforcerTest

Christian Kuhn CR +2 V +2 Easy +1 −8 updated 04/07/21, 09:05

Commit message

Usage of real instances in tests avoid the awkward situation
that the test might not be useful anymore due to refactoring
and reworking over time without anyone noticing.
Mocks must only be used if necessary.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Christian Kuhn commented on patch set 1 04/07/21, 08:34

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/07/21, 08:43 Completed build in 08m 22s on Wed, 7 Apr, 08:43 AM Test Summary: 75946 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1294

  3. core-ci voted on patch set 1 V +1 04/07/21, 08:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2070

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 04/07/21, 09:05

  5. Christian Kuhn merged patch set 2 04/07/21, 09:05