Review 10.4 Merged

68992[BUGFIX] Ensure MountPoint parameter contains valid characters

Benni Mack CR +2 V +2 Normal +67 −0 updated 05/04/21, 15:22

Commit message

When using ?MP=12-13,345-673 some could also add a
letter or a "/" symbol in the GET parameter, effectively
showing a 503 instead of 404 page. This change ensures
that $TSFE->MP only contains numbers, commas or dashes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 05/04/21, 09:54

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 05/04/21, 10:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11090

  3. Benni Mack uploaded patch set 2 05/04/21, 14:46

  4. core-ci voted on patch set 2 V +1 05/04/21, 14:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11124

  5. Benni Mack voted on patch set 2 V +2 CR +2 05/04/21, 15:22

  6. Benni Mack merged patch set 3 05/04/21, 15:22