Review 10.4 Merged

70555[BUGFIX] Fix FileSpoolTest creating "spool" directory on root level

Benni Mack CR +2 V +2 Easy +2 −1 updated 08/13/21, 11:44

Commit message

The FileSpoolTest is creating a directory "spool" on root level.
Unit tests should never create directories on the root level of
TYPO3 project. Instead use `Environment::getVarPath()` as path.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 08/13/21, 11:13

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 08/13/21, 11:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14944

  3. Benni Mack voted on patch set 1 V +2 CR +2 08/13/21, 11:44

  4. Benni Mack merged patch set 2 08/13/21, 11:44