Review main Work in progress Orphaned Breaking

70586[!!!][BUGFIX] Merge form variants finisher options

Mathias Brodala CR 0 V 0 Easy +34 −5 updated 10/11/24, 09:27

Commit message

Finishers and their options defined in form variants are now merged with
the basic finishers list of the form. This allows for selectively
changing finisher options in form variants.

At the same time this also means that the finishers list is not reset
anymore for variants, thus form definitions must be adjusted
accordingly, e.g. by explicitly disabling finishers via variants.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 12
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/70586/12 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/70586/12 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 1

Files 4

Review log 1628

Show 23 earlier messages
  1. Mathias Brodala uploaded patch set 1 08/13/21, 16:36

  2. Mathias Brodala marked it work in progress 08/13/21, 16:36

  3. core-ci voted on patch set 1 V -1 08/13/21, 16:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15001

  1. Mathias Brodala uploaded patch set 2 08/14/21, 12:24

  2. core-ci voted on patch set 2 V -1 08/14/21, 12:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15067

  3. Mathias Brodala uploaded patch set 3 08/14/21, 12:31

  4. core-ci voted on patch set 3 V -1 08/14/21, 12:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15068

  5. Mathias Brodala uploaded patch set 4 08/14/21, 12:56

  6. Mathias Brodala uploaded patch set 5 08/14/21, 12:57

  7. core-ci voted on patch set 4 V -1 08/14/21, 12:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15072

  8. core-ci voted on patch set 5 V -1 08/14/21, 13:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15073

  9. Björn Jacob updated the commit message in patch set 6 09/02/21, 07:48

  10. core-ci voted on patch set 6 V -1 09/02/21, 08:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16052

  11. Benni Mack wrote 11/29/21, 10:09

    Change destination moved from master to main
  12. Benni Mack updated the commit message in patch set 7 11/29/21, 13:25

  13. core-ci voted on patch set 7 V -1 11/29/21, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20024

  14. Elias Häußler uploaded patch set 8 04/28/22, 10:07

  15. core-ci voted on patch set 8 V -1 04/28/22, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26563

  16. Elias Häußler uploaded patch set 9 04/28/22, 10:26

  17. Elias Häußler uploaded patch set 10 04/28/22, 10:30

  18. Elias Häußler uploaded patch set 11 04/28/22, 10:33

  19. core-ci voted on patch set 9 V -1 04/28/22, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26565

  20. core-ci voted on patch set 11 V +1 04/28/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26567

  21. core-ci voted on patch set 10 V -1 04/28/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26566

  22. Stefan Froemken commented on patch set 11 V +1 CR +1 08/18/22, 10:30

    As that feature is already described in the documentation it's time to get that merged: Quote: "setting finisher options depending on the value of a form element" https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Concepts/Variants/Index.html?highlight=applicationcontext#basics
  23. Patrick Schriner commented on patch set 11 08/02/23, 11:37

    This should be covered by some tests
  24. Mathias Brodala uploaded patch set 12 CR +1 V +1 10/11/24, 08:55

  25. core-ci voted on patch set 12 V +1 10/11/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67572