Review 11.5 Merged

73077[BUGFIX] Avoid calling trim(null) in ContentObjectRenderer

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 01/19/22, 14:17

Commit message

'ContentObjectRenderer->stdWrap()' calls subfunction starting
with 'stdWrap_' which may not only return strings, but also int,
boolean, null and so on, thus eventually feeding 'trim()' with
null or a non string value to which emits a PHP8.0 warning and
an type error on PHP8.1.

To mitigate this string cast is added on the value for the
'trim(...)' call to be close to the spot and do not change
behaviour for now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 01/19/22, 13:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/19/22, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22269

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/19/22, 14:17

  4. Christian Kuhn merged patch set 2 01/19/22, 14:17