Review 11.5 Merged

73169[BUGFIX] Fix "undefined array key" issues in LiveSearch's page jump

Andreas Kienast CR +2 V +2 Easy +8 −8 updated 01/31/22, 07:30

Commit message

This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases uid and pid) is queried, which
is the case when using the "page jump" feature.

As a drive-by, these issues are fixed as well:
* Pass `$queryBuilder` as a reference, which makes no sense for objects
* Adding SQL constraints twice

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 01/31/22, 06:52

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/31/22, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22774

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 01/31/22, 07:30

  4. Andreas Kienast merged patch set 2 01/31/22, 07:30