Review 11.5 Merged

73957[BUGFIX] Prevent TypeError for unsupported operand types

Oli Bartsch CR +2 V +2 Easy +3 −8 updated 03/21/22, 15:32

Commit message

Since bitwise operators requires the operands to be
integers, a possible raw database value for a checkbox
element is now properly casted, before used as operand,
preventing a TypeError.

Note: PHP < 8, this only triggered a warning.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch commented on patch set 1 03/21/22, 15:21

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/21/22, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25031

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 03/21/22, 15:32

  4. Oli Bartsch merged patch set 2 03/21/22, 15:32