Review main Merged

74492[BUGFIX] Preserve form finisher select values

Elias Häußler CR +2 V +2 Hard +871 −26 updated 11/14/26, 09:58

Commit message

Form finisher options provide FormEngine configuration for rendering
fields inside FlexForm overrides. This configuration was passed through
`TranslationService::translateValuesRecursive()` as a whole. The form
editor translated its definitions the same way.

As a result, not only labels but also technical configuration values
were translated. The item value "default" of the `translation.language`
option of email finishers was stored as its backend label, for example
"Default" or "Standard", in form plugins and in form definitions. Such
a value matches no configured item and forces emails into the default
language.

Restrict translation of FlexForm overrides to textual FormEngine
properties: labels, descriptions, placeholders, section titles, labels
of item groups and labels of legacy numeric select items. The form
editor keeps the values of select options untranslated.

An upgrade wizard replaces every non-empty value of the option that is
not a valid language key by "default" in form plugins and in form
definitions stored in the database. An Important changelog entry
documents the new translation behavior and the migration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 6189

Show 4564 earlier messages
  1. Elias Häußler uploaded patch set 1 04/29/22, 12:48

  2. Elias Häußler marked it work in progress 04/29/22, 12:51

  3. Elias Häußler updated the commit message in patch set 2 04/29/22, 12:51

  4. core-ci voted on patch set 1 V -1 04/29/22, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26659

  5. core-ci voted on patch set 2 V -1 04/29/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26660

  6. Elias Häußler uploaded patch set 3 04/29/22, 15:21

  7. Elias Häußler uploaded patch set 4 04/29/22, 15:24

  8. core-ci voted on patch set 3 V -1 04/29/22, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26680

  9. core-ci voted on patch set 4 V -1 04/29/22, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26681

  10. Elias Häußler uploaded patch set 5 04/29/22, 15:43

  11. core-ci voted on patch set 5 V +1 04/29/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26682

  12. Elias Häußler uploaded patch set 6 04/29/22, 19:19

  13. Elias Häußler marked it ready for review 04/29/22, 19:19

  14. core-ci voted on patch set 6 V -1 04/29/22, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26684

  15. Elias Häußler rebased onto patch set 7 05/02/22, 06:37

  16. core-ci voted on patch set 7 V +1 05/02/22, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26720

  17. Björn Jacob updated the commit message in patch set 8 06/29/22, 08:06

  18. core-ci voted on patch set 8 V -1 06/29/22, 08:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28470

  19. Björn Jacob commented on patch set 9 06/29/22, 08:16

    Published edit on patch set 8.
  20. core-ci voted on patch set 9 V -1 06/29/22, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28471

  21. Björn Jacob commented on patch set 9 CR -1 06/29/22, 08:21

    Awesome patch. I have adapted some things in the light of the upcoming namespace change. One minor request: when reading the commit msg I felt like "this is breaking". Later on, I found your important.rst. Which is great. Can you please add an additional paragraph to the commit msg explaining why it is not considered as breaking and a rst file is provided for more information? That would be terrific 😊
  22. core-ci commented on patch set 9 06/29/22, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28471

  23. Elias Häußler uploaded patch set 10 06/29/22, 08:47

  24. Elias Häußler commented on patch set 10 06/29/22, 08:48

    Reply

    Done
  25. core-ci voted on patch set 10 V +1 06/29/22, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28474

  26. Björn Jacob voted on patch set 10 CR +1 06/29/22, 08:56

  27. Björn Jacob commented on patch set 10 CR -1 06/29/22, 09:23

    The namespace change requires to get rid of the "Form" part as well. The configuration starts with "prototypes".
  28. Björn Jacob commented on patch set 10 06/29/22, 09:29

    If we backport it to v11 should the rst be placed in the v11 changelog folder? I don't know the rule. I am tending to not backport it.
  29. Elias Häußler uploaded patch set 11 06/29/22, 09:42

  30. Elias Häußler commented on patch set 11 06/29/22, 09:43

    Reply

    Done

    Reply

    Done, removed the v11 backport.
    wi
  31. Björn Jacob voted on patch set 11 CR +1 06/29/22, 09:45

  32. core-ci voted on patch set 11 V +1 06/29/22, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28477

  33. waldhacker commented on patch set 11 06/30/22, 09:49

    TranslationService.php:254

    yoda conditions we do not want
  34. Elias Häußler commented on patch set 11 06/30/22, 10:06

    TranslationService.php:254 Reply

    If the core team agrees on not using yoda style, then this should probably added to the PHP-CS-Fixer config. Currently, yoda style is used 18 times across core.
  35. Elias Häußler uploaded patch set 12 06/30/22, 10:09

  36. core-ci voted on patch set 12 V +1 06/30/22, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28524

  37. Tobias Jungmann voted on patch set 12 CR +1 06/30/22, 13:24

  38. Elias Häußler commented on patch set 12 07/01/22, 09:38

    TranslationService.php:254 Reply

    Done
  39. Björn Jacob voted on patch set 12 CR +1 07/01/22, 09:53

  40. Elias Häußler uploaded patch set 13 10/13/22, 11:17

  41. core-ci voted on patch set 13 V +1 10/13/22, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32288

  42. Benni Mack updated the commit message in patch set 14 V +1 05/03/23, 09:53

  43. Benni Mack updated the commit message in patch set 15 10/18/24, 14:06

  44. Elias Häußler uploaded patch set 16 01/23/25, 10:17

  45. core-ci voted on patch set 16 V -1 01/23/25, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72916

  46. Elias Häußler uploaded patch set 17 V -1 01/23/25, 10:25

  47. core-ci voted on patch set 17 V +1 01/23/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72917

  48. Elias Häußler rebased onto patch set 18 V +1 03/28/25, 09:14

  49. Benni Mack wrote 03/28/25, 09:14

    Topic set to form
  50. core-ci voted on patch set 18 V +1 03/28/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76558

  51. Andreas Kienast commented on patch set 18 CR -1 04/14/25, 14:03

    TranslationService.php:137

    We don't use named arguments outside of DTO context.
  52. Andreas Kienast uploaded patch set 19 CR -1 V +1 04/14/25, 14:05

  53. core-ci voted on patch set 19 V +1 04/14/25, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77702

  54. Andreas Kienast commented on patch set 19 CR +1 04/14/25, 14:34

    TranslationService.php:137 Reply

    Done
  55. Josua Vogel commented on patch set 19 CR +1 V +1 07/21/25, 14:26

    tested and it worked for me
  56. Oli Bartsch commented on patch set 19 07/24/25, 15:03

    Patch is working as expected. For example "settings.finishers.EmailToSender.translation.language" does no longer have "Default" or "Standard" (for DE backend) as value, but always "default". However this now breaks all configs because the current value is no longer valid. Should we handle this with an automatic migration?
  57. Elias Häußler commented on patch set 19 08/12/25, 13:06

    Reply

    Can you elaborate on "the current value is no longer valid"? Because I'm actually not quite sure what you mean with that. 😬 If we can provide a proper migration to avoid possible breaking changes, I'd happy to implement it. 😊
  58. Oli Bartsch commented on patch set 19 08/13/25, 09:39

    Reply

    I've added screenshots to the issue: * https://forge.typo3.org/attachments/39791 * https://forge.typo3.org/attachments/39790 The problem is, without the patch applied (current behaviour) When I select the default language, based on the users system language, e.g. "Default" or "Standard" is stored as value in the DB. With your patch applied, the default translations identifier is correctly "default", no matter of the users system language. However this therefore makes the current DB value invalid, falling back to "auto".
  59. Elias Häußler commented on patch set 19 08/13/25, 10:42

    Reply

    Ah, now I got it. Thanks for clarification. Do you have any ideas how to implement such migration? I currently don't have a good solution for this problem.
  60. Oli Bartsch commented on patch set 19 08/14/25, 15:38

    Reply

    I don't know ad-hoc. Maybe have a UpgradeWizard migrating the values in the database. However not quite sure how the detection for every possible language can be achieved.
  61. Oli Bartsch commented on patch set 19 08/14/25, 15:42

    Reply

    Just saw, that this should be backported. Did you check if using "Default" or "Standard" does currently have any effect at all? Otherwise I think it would be fine to merge as is.
  62. Benni Mack updated the commit message in patch set 20 CR +1 V +1 04/22/26, 06:33

  63. core-ci voted on patch set 20 V -1 04/22/26, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100730

  64. Josua Vogel uploaded patch set 21 V -1 09/03/26, 10:57

  1. core-ci voted on patch set 21 V +1 09/03/26, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107743

  2. Oli Bartsch uploaded patch set 22 V +1 11/10/26, 13:17

  3. Oli Bartsch commented on patch set 22 11/10/26, 13:19

    Reply

    Done
  4. core-ci voted on patch set 22 V -1 11/10/26, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113901

  5. Josua Vogel uploaded patch set 23 V -1 11/10/26, 14:04

  6. core-ci voted on patch set 23 V +1 11/10/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113906

  7. Josua Vogel uploaded patch set 24 V +1 11/11/26, 09:27

  8. core-ci voted on patch set 24 V +1 11/11/26, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114028

  9. Josua Vogel voted on patch set 24 CR +1 V +1 11/11/26, 09:43

  10. Josua Vogel updated the commit message in patch set 25 CR +1 V +1 11/11/26, 11:43

  11. core-ci voted on patch set 25 V +1 11/11/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114066

  12. Josua Vogel uploaded patch set 26 V +1 11/11/26, 12:31

  13. core-ci voted on patch set 26 V +1 11/11/26, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114070

  14. Josua Vogel voted on patch set 26 CR +1 V +1 11/11/26, 12:52

  15. Oli Bartsch uploaded patch set 27 CR +1 V +1 11/11/26, 18:06

  16. core-ci voted on patch set 27 V +1 11/11/26, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114135

  17. Oli Bartsch uploaded patch set 28 V +1 11/12/26, 09:50

  18. core-ci voted on patch set 28 V +1 11/12/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114175

  19. Oli Bartsch uploaded patch set 29 V +1 11/12/26, 11:08

  20. Oli Bartsch voted on patch set 29 CR +1 V +1 11/12/26, 11:09

  21. core-ci voted on patch set 29 V +1 11/12/26, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114181

  22. Josua Vogel voted on patch set 29 CR +1 V +1 11/13/26, 08:39

  23. Simon Schaufelberger voted on patch set 29 CR +1 V +1 11/13/26, 10:10

  24. Oli Bartsch voted on patch set 29 CR +2 V +2 11/14/26, 09:58

  25. Oli Bartsch merged patch set 30 11/14/26, 09:58