#87675email2sender finisher: labels not translated correctly when override finisher settings is used
Description
I’ve got an installation with german and english localization. My forms are translated and presented in the correct language. Everything is fine except one point: The EmailToSender finisher.
It seems like
{formvh:translateElementProperty(element: formValue.element, property: 'label')}
The same line for EmailToReceiver finisher returns the correct translated label. But in EmailToSender finisher I get the english label no matter with which language I fill the form.
the typoscript settings
config {
// Language Settings
linkVars := addToList(L(0-2))
sys_language_uid = 0
sys_language_overlay = 1
sys_language_mode = content_fallback
language = de
locale_all = de_DE.UTF-8
htmlTag_langKey = de-DE
# for real url
defaultGetVars {
L = 0
}
sys_language_softMergeIfNotBlank = tt_content:image, pages:media
}
[globalVar = GP:L = 1]
config {
sys_language_uid = 1
language = en
locale_all = en_EN.UTF-8
htmlTag_langKey = en-GB
}
[global]
[globalVar = GP:L = 2]
config {
sys_language_uid = 4
language = fr
locale_all = fr_FR.UTF-8
htmlTag_langKey = fr-FR
}
[global]
The localization files:
Forms.xlf
<?xml version="1.0" encoding="utf-8" standalone="yes" ?>
<xliff version="1.0">
<file source-language="en" datatype="plaintext" original="messages" date="2018-12-03T20:38:10Z">
<header>
<description>Formular Labels.</description>
<generator>LFEditor</generator>
</header>
<body>
<trans-unit id="element.f_firstName.properties.label">
<source><![CDATA[First name]]></source>
</trans-unit>
</body>
</file>
</xliff>
de.Forms.xlf
<?xml version="1.0" encoding="utf-8" standalone="yes" ?>
<xliff version="1.0">
<file source-language="en" target-language="de" datatype="plaintext" original="messages" date="2018-12-03T20:38:10Z">
<header>
<description>Formular Labels.</description>
<generator>LFEditor</generator>
</header>
<body>
<trans-unit id="element.f_firstName.properties.label" approved="yes">
<source><![CDATA[First name]]></source>
<target><![CDATA[Vorname]]></target>
</trans-unit>
</body>
</file>
</xliff>
The form definition:
renderingOptions:
submitButtonLabel: 'Anfrage absenden ...'
type: Form
identifier: ...Konfigurator
label: '...Konfigurator'
prototypeName: ...KonfiguratorBase
finishers:
-
options:
...
templatePathAndFilename: '.../Customer.html'
identifier: EmailToSender
-
options:
...
templatePathAndFilename: '.../Company.html'
identifier: EmailToReceiver
-
renderables:
-
renderingOptions:
previousButtonLabel: 'Previous step'
nextButtonLabel: 'Neue Seite'
type: Page
identifier: page-1
label: ''
renderables:
-
defaultValue: ''
type: Text
identifier: f_firstName
label: Vornamen!!!123
properties:
fluidAdditionalAttributes:
required: required
elementDescription: given-name
validators:
-
identifier: NotEmpty
the Template file: company.html and customer.html are identical:
{namespace formvh=TYPO3\CMS\Form\ViewHelpers}
{namespace v=FluidTYPO3\Vhs\ViewHelpers}
<html xmlns:f="https://xsd.helhum.io/ns/typo3/cms-fluid/master/ViewHelpers"
xmlns:v="http://typo3.org/ns/FluidTYPO3/Vhs/ViewHelpers"
xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="format-detection" content="telephone=no">
</head>
<body>
<table width="600" cellpadding="0" cellspacing="0" border="0">
<tr>
<td colspan="2" width="1200" align="left">
<f:render section="replacePlaceholders" arguments="{form:form, uid:'EmailIntro'}"/> <br/>
</td>
</tr>
<formvh:renderAllFormValues renderable="{form.formDefinition}" as="formValue">
<tr>
<td width="600" valign="top" align="left">{formvh:translateElementProperty(element: formValue.element, property: 'label')}</td>
<td width="600" valign="top" align="left">
<f:if condition="{formValue.value}">
<f:then>
<f:if condition="{formValue.isMultiValue}">
<f:then>
<table cellspacing="0" border="0">
<f:for each="{formValue.processedValue}" as="value">
<tr>
<td>{value}</td>
</tr>
</f:for>
</table>
</f:then>
<f:else>
<table cellspacing="0" border="0">
<tr>
<td><f:format.nl2br>{formValue.processedValue}</f:format.nl2br></td>
</tr>
</table>
</f:else>
</f:if>
</f:then>
<f:else>
-
</f:else>
</f:if>
</td>
</tr>
</formvh:renderAllFormValues>
<tr>
<td colspan="2" width="1200" align="left"> <br/>
<f:render section="replacePlaceholders" arguments="{form:form, uid:'EmailOutro'}"/>
</td>
</tr>
</table>
</body>
<f:section name="replacePlaceholders">
<v:variable.set name="messageUid" value="{v:variable.typoscript(path: 'plugin.tx_form.settings.UIDs.{form.identifier}.{uid}')}"/>
<v:variable.set name="message" value="{v:content.render(contentUids:{0:messageUid})}"/>
<formvh:renderAllFormValues renderable="{form.formDefinition}" as="formValue">
<v:variable.set name="message">
<v:format.replace content="{message}"
substring="[{formValue.element.identifier}]"
replacement="{formValue.processedValue}"/>
</v:variable.set>
</formvh:renderAllFormValues>
<f:format.raw>{message}</f:format.raw>
</f:section>
</html>
Summary:
All contents and translation in EmailToReceiver is correct in both languages. EmailToSender form labels are always english. Everything else is correct.
Is there a configuration error?
Reviews 2
Related issues 3
Files 2
History 2454
Show 1829 earlier messages
-
Björn Jacob changed Sprint Focus Remote Sprint <span data-processor="relativetime" data-value="2019-04-04T19:48:08+00:00" > 04/04/19, 19:48 </span>
-
Susanne Moog changed status
NewIn Progress assigned to user 44416 <span data-processor="relativetime" data-value="2019-04-25T13:27:48+00:00" > 04/25/19, 13:27 </span> -
Daniela Pohl commented and changed status
In ProgressNew removed the assignee <span data-processor="relativetime" data-value="2019-04-25T17:02:42+00:00" > 04/25/19, 17:02 </span> -
Björn Jacob commented and changed status
NewNeeds Feedback assigned to Aurelius Hogan <span data-processor="relativetime" data-value="2019-04-25T17:25:17+00:00" > 04/25/19, 17:25 </span>Aurelius, as you can see we cannot reproduce the issue. Can you further test your installation and provide us with more insight (installed extensions etc.)? Do you use the bootstrap package?
-
Björn Jacob changed Sprint Focus
Remote Sprint<span data-processor="relativetime" data-value="2019-04-27T19:31:24+00:00" > 04/27/19, 19:31 </span> -
Jürgen Venne commented <span data-processor="relativetime" data-value="2019-04-29T11:37:54+00:00" > 04/29/19, 11:37 </span>
I’ve the same issue here on a multidomain (3 sites), multilanguage (15 languages) site.
It breaks down to the RenderingOptions in TranslateElementPropertyViewHelper.
The RenderingOptions are null so no language can be determined and the default english labels are rendered.As a workaround I use this Fluid code:
<f:variable name="lll" value="LLL:EXT:fancysitepackage/Resources/Private/Extensions/form/language/locallang.xlf" /> <f:translate key='{lll}:contactform.element.{formValue.element.identifier}.properties.label' default="{formValue.element.identifier}" /> -
Susanne Moog changed Sprint Focus Remote Sprint <span data-processor="relativetime" data-value="2019-11-17T18:26:24+00:00" > 11/17/19, 18:26 </span>
-
Björn Jacob changed Sprint Focus
Remote Sprint<span data-processor="relativetime" data-value="2019-11-24T12:25:46+00:00" > 11/24/19, 12:25 </span> -
Björn Jacob commented and changed status
Needs FeedbackNew removed the assignee Sprint Focus Remote Sprint <span data-processor="relativetime" data-value="2020-04-13T11:22:29+00:00" > 04/13/20, 11:22 </span>Let’s check this again and see what Jürgen did :) If this only occurs on v8 we will not fix the issue (v8 is in ELTS phase now).
-
Jarvis H commented <span data-processor="relativetime" data-value="2020-04-20T17:45:57+00:00" > 04/20/20, 17:45 </span>
I too can confirm this issue and in Typo3 9.5.14.
After checking through all the source code translation steps, I discovered that the problem has to do with the flexform finisher override settings.
When I activate the “Override finisher settings” option in the plugin, the following is added to the saved flexform data:
<field index="settings.finishers.EmailToReceiver.translation.language"> <value index="vDEF">Default</value> </field>Internally this causes the value of $languageKey in
TYPO3\CMS\Form\Service\TranslationServiceto be set to ‘Default’ which of course is not valid, hence the e-mail translations are shown in the wrong language. (Note: the value is dependent on your current BE-language in Typo3, so if switching to German, the saved value becomes ‘Standard’ instead of ‘Default’)If changing the saved flexform data to this, or simply not overriding the finisher settings at all, the problem goes away:
<field index="settings.finishers.EmailToReceiver.translation.language"> <value index="vDEF"></value> </field>What I don’t understand however is why this flexform setting is rendered as a select field at all, or rather how is it supposed to be used?
Hope this helps any further debugging of the issue.
-
Jarvis H commented <span data-processor="relativetime" data-value="2020-05-07T18:43:42+00:00" > 05/07/20, 18:43 </span>
EDIT adding additional information:
(I am not completely sure if my issue is the same as for the other people in this thread.)
To further clarify, I tracked down the translation label in my local var/labels/de/form/Resources/Private/Language/de.Database.xlf. Oddly enough it states as note: “@This label is deprecated (not used anymore) since TYPO3v8@” which is not true as it is used as translation for
settings.finishers.EmailToReceiver.translation.languagewhen enabling the “Override finisher settings” option and using the EmailToReceiver finisher. This would indicate that a translation of a select field option value is inadvertently taking place.<trans-unit id="default" resname="default" xml:space="preserve" approved="yes"> <source>Default</source> <target state="translated">Standard</target> <note>This label is deprecated (not used anymore) since TYPO3v8</note> <alt-trans xml:space="preserve" origin="cicom"> <target>Vorgabe</target> </alt-trans> </trans-unit>—-
I also tested how translations are working in EmailToSender and noticed, that there is an additional bug at play here. Any language settings for EmailToReceiver (i.e. forcing a language for any labels in the receiver mail, fx. always setting receiver mails to be german regardless of FE-language) will also be used in EmailToSender. As far as I can tell the reason for this is, they both use
TYPO3\CMS\Form\Service\TranslationServicewhich is a singleton.TYPO3\CMS\Form\Domain\Finishers\EmailFinisheruses theTranslationService->setLanguagemethod and any value set here is then also used in EmailToSender.It feels like this singleton should not have such a getter method, as it causes unforeseen consequences in other locations.
-
Axel Hahn commented and changed subject
form framework email2sender finisher: labels not translatedform framework email2sender finisher: labels not translated correctly when vverride finisher settings is used TYPO3 Version89 <span data-processor="relativetime" data-value="2020-11-18T14:59:02+00:00" > 11/18/20, 14:59 </span>I am facing the same problem with typo3 version 9.5.23.
My translations used in the EmailToSender / EmailToReceiver finishers are working as expected until I set the “Override finisher settings” option to true.
All elements which are translated by using{formvh:translateElementProperty(element: formValue.element, property: 'placeholder')}are shown in the default language instead of the selected one.
Whereas elements which are translated by using<f:translate key="LLL:EXT:my_site_package/Resources/Private/Language/locallang_forms_email.xlf:email.yes"/>are translated correctly.
-
Martin Schulz commented <span data-processor="relativetime" data-value="2020-12-07T16:23:18+00:00" > 12/07/20, 16:23 </span>
Same issue for TYPO3 10.4.10
-
Stefan Hekele commented <span data-processor="relativetime" data-value="2020-12-15T13:01:44+00:00" > 12/15/20, 13:01 </span>
TYPO3 10.4.10:
If I edit typo3/sysext/form/Configuration/Yaml/Finishers/EmailToReceiver.yaml and typo3/sysext/form/Configuration/Yaml/Finishers/EmailToSender.yaml to change the following:
items: 10: - tt_content.finishersDefinition.EmailToReceiver.language.1 - defaultto
items: 10: - tt_content.finishersDefinition.EmailToReceiver.language.1I have the, for me, expected behaviour. The dropdown value default is an empty string, and the Email Finishers use the current frontend language.
Without the change, there is also another issue just in the backend itself. ‘default’ ist being translated as it is defined in the forms xlf. So if you edit a form as a user with an English Backend, and then Switch over to, for example, German, the form value will be marked as invalid, as the label changes between the two languages. -
Ge Rie changed Related to #93806 <span data-processor="relativetime" data-value="2021-07-02T09:22:54+00:00" > 07/02/21, 09:22 </span>
-
Björn Jacob commented and changed subject
form framework email2sender finisher: labels not translated correctly when vverride finisher settings is usedemail2sender finisher: labels not translated correctly when override finisher settings is used TYPO3 Version911 <span data-processor="relativetime" data-value="2021-08-06T11:48:54+00:00" > 08/06/21, 11:48 </span>Have to check the new information and try to reproduce the problem.
-
Björn Jacob changed
Related to #93806<span data-processor="relativetime" data-value="2021-08-06T11:50:16+00:00" > 08/06/21, 11:50 </span> -
Björn Jacob changed description <span data-processor="relativetime" data-value="2022-04-28T06:19:41+00:00" > 04/28/22, 06:19 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 74492 status
NewUnder Review <span data-processor="relativetime" data-value="2022-04-29T12:48:53+00:00" > 04/29/22, 12:48 </span> -
Gerrit Code Review pushed patch set 2 for main to change 74492 <span data-processor="relativetime" data-value="2022-04-29T12:51:45+00:00" > 04/29/22, 12:51 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 74492 <span data-processor="relativetime" data-value="2022-04-29T15:21:26+00:00" > 04/29/22, 15:21 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 74492 <span data-processor="relativetime" data-value="2022-04-29T15:24:22+00:00" > 04/29/22, 15:24 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 74492 <span data-processor="relativetime" data-value="2022-04-29T15:43:32+00:00" > 04/29/22, 15:43 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 74492 <span data-processor="relativetime" data-value="2022-04-29T19:19:07+00:00" > 04/29/22, 19:19 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 74492 <span data-processor="relativetime" data-value="2022-05-02T06:37:15+00:00" > 05/02/22, 06:37 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 74492 <span data-processor="relativetime" data-value="2022-06-29T08:06:50+00:00" > 06/29/22, 08:06 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 74492 <span data-processor="relativetime" data-value="2022-06-29T08:16:45+00:00" > 06/29/22, 08:16 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 74492 <span data-processor="relativetime" data-value="2022-06-29T08:47:45+00:00" > 06/29/22, 08:47 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 74492 <span data-processor="relativetime" data-value="2022-06-29T09:42:12+00:00" > 06/29/22, 09:42 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 74492 <span data-processor="relativetime" data-value="2022-06-30T10:09:18+00:00" > 06/30/22, 10:09 </span>
-
Björn Jacob changed Related to #97839 <span data-processor="relativetime" data-value="2022-07-01T08:36:05+00:00" > 07/01/22, 08:36 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 74492 <span data-processor="relativetime" data-value="2022-10-13T11:17:02+00:00" > 10/13/22, 11:17 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 74492 <span data-processor="relativetime" data-value="2023-05-03T09:53:41+00:00" > 05/03/23, 09:53 </span>
-
Netresearch DTT GmbH commented <span data-processor="relativetime" data-value="2023-11-23T12:54:13+00:00" > 11/23/23, 12:54 </span>
Is there a chance this will be fixed soon? It’s a really ugly bug for a multilingual production environment.
I applied patchset 12 to TYPO3 11.5 (13 and 14 only introduced the EventListener) and this does not solve the problem for me that when the option “Override finisher settings [settings.overrideFinishers]” is activated, the output in the mail template is according to the current frontend language, but still is in English (presumably the default).
-
Bernhard Eckl changed Related to #103899 <span data-processor="relativetime" data-value="2024-06-03T09:41:30+00:00" > 06/03/24, 09:41 </span>
-
Gerrit Code Review pushed patch set 15 for main to change 74492 <span data-processor="relativetime" data-value="2024-10-18T14:06:52+00:00" > 10/18/24, 14:06 </span>
-
Gerrit Code Review pushed patch set 16 for main to change 74492 <span data-processor="relativetime" data-value="2025-01-23T10:17:16+00:00" > 01/23/25, 10:17 </span>
-
Gerrit Code Review pushed patch set 17 for main to change 74492 <span data-processor="relativetime" data-value="2025-01-23T10:25:22+00:00" > 01/23/25, 10:25 </span>
-
Gerrit Code Review pushed patch set 18 for main to change 74492 <span data-processor="relativetime" data-value="2025-03-28T09:14:49+00:00" > 03/28/25, 09:14 </span>
-
Gerrit Code Review pushed patch set 19 for main to change 74492 <span data-processor="relativetime" data-value="2025-04-14T14:05:54+00:00" > 04/14/25, 14:05 </span>
-
Oliver Bartsch commented and changed attached from-en.png attached from-de.png <span data-processor="relativetime" data-value="2025-08-13T09:37:14+00:00" > 08/13/25, 09:37 </span>
-
Gerrit Code Review pushed patch set 20 for main to change 74492 <span data-processor="relativetime" data-value="2026-04-22T06:33:24+00:00" > 04/22/26, 06:33 </span>
-
Gerrit Code Review pushed patch set 21 for main to change 74492 <span data-processor="relativetime" data-value="2026-09-03T10:57:17+00:00" > 09/03/26, 10:57 </span>
-
Gerrit Code Review pushed patch set 22 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-10T13:17:09+00:00" > 11/10/26, 13:17 </span>
-
Gerrit Code Review pushed patch set 23 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-10T14:04:14+00:00" > 11/10/26, 14:04 </span>
-
Gerrit Code Review pushed patch set 24 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-11T09:27:18+00:00" > 11/11/26, 09:27 </span>
-
Gerrit Code Review pushed patch set 25 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-11T11:43:06+00:00" > 11/11/26, 11:43 </span>
-
Gerrit Code Review pushed patch set 26 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-11T12:31:15+00:00" > 11/11/26, 12:31 </span>
-
Gerrit Code Review pushed patch set 27 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-11T18:06:47+00:00" > 11/11/26, 18:06 </span>
-
Gerrit Code Review pushed patch set 28 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-12T09:50:58+00:00" > 11/12/26, 09:50 </span>
-
Gerrit Code Review pushed patch set 29 for main to change 74492 <span data-processor="relativetime" data-value="2026-11-12T11:08:58+00:00" > 11/12/26, 11:08 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 97580 <span data-processor="relativetime" data-value="2026-11-12T16:34:33+00:00" > 11/12/26, 16:34 </span>
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-14T10:05:12+00:00" > 11/14/26, 10:05 </span>Applied in changeset commit:f0847b0f7ce36f302f91fe1d36fd7b2418580ec6.
-
Aristeidis Karavas changed Related to #111515 <span data-processor="relativetime" data-value="2026-11-20T09:16:56+00:00" > 11/20/26, 09:16 </span>
I can not reproduce the issue.
Set up german and english localization, created a form with emailToSender and emailToReceiver finishers and used the company.html to overwrite the Template Path. Labels are always in correct language.
form.yaml
locallang.xlf
de.locallang.xlf