Review 11.5 Merged

74696[BUGFIX] Resolve type issues in SemaphoreLockStrategy

Benni Mack CR +2 V +2 Easy +2 −12 updated 05/20/22, 08:30

Commit message

ftok() doesn't return false, but -1 on error.

The $resource property may be null to indicate no lock
is active, so allow that.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 05/20/22, 06:34

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  2. Benni Mack commented on patch set 2 05/20/22, 06:35

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 05/20/22, 06:35

  4. core-ci voted on patch set 1 V -1 05/20/22, 06:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27337

  5. core-ci voted on patch set 2 V +1 05/20/22, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27338

  6. Benni Mack voted on patch set 2 V +2 CR +2 05/20/22, 08:30

  7. Benni Mack merged patch set 3 05/20/22, 08:30