Review 11.5 Merged

74755[BUGFIX] Take dev mode into account for package hash

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 05/25/22, 11:14

Commit message

When generating the identifier for the package artifact,
not only the hash from the composer.lock must be taken
into account, but also whether packages have been installed
in dev mode or not.

Since dev mode does not change the lock hash, it otherwise
can happen that a stale DI cache with invalid set of
packages is used, which obviously leads to fatal errors

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2

Issues 1

Files 1

Review log 45

  1. Helmut Hummel commented on patch set 1 05/25/22, 11:06

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 05/25/22, 11:09

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 05/25/22, 11:11

  4. Christian Kuhn merged patch set 2 05/25/22, 11:11

  5. core-ci voted on patch set 1 V +1 05/25/22, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27446