74834[BUGFIX] Apply empty values in language-overlay
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1216
-
Benni Mack commented on patch set 1 06/08/22, 11:38
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php * typo3/sysext/core/Tests/Functional/Fixtures/pages.csv -
Benni Mack commented on patch set 2 06/08/22, 11:39
Published edit on patch set 1. -
Benni Mack marked it ready for review 06/08/22, 11:39
-
core-ci voted on patch set 1 V -1 06/08/22, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27807
-
core-ci voted on patch set 2 V -1 06/08/22, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27808
-
André Buchmann uploaded patch set 3 06/08/22, 13:51
-
core-ci voted on patch set 3 V -1 06/08/22, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27823
-
André Buchmann uploaded patch set 4 06/08/22, 14:05
-
core-ci voted on patch set 4 V +1 06/08/22, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27824
-
André Buchmann commented on patch set 4 06/08/22, 14:23
PageRepositoryTest.php:629With php7.4 the return type is string instead of integer here. I used the type casting here, but we can also use self::assertEquals() if you prefer? -
Oliver Klee commented on patch set 4 06/08/22, 15:03
PageRepositoryTest.php:629ReplyAre you really sure the return type is PHP-version-specific? I'd recommend keeping the comparison as strict as possible (without any casts). If $overlaidRecord['_LOCALIZED_UID'] is a string, this would look like this: self::assertSame('2', $overlaidRecord['_LOCALIZED_UID']); -
André Buchmann commented on patch set 4 06/09/22, 05:44
PageRepositoryTest.php:629ReplyYep, I'm sure that php 8.1 returns int and 7.4 + 8.0 are returning a string. I've tested both variants with this test call (changed only the php-version) in my local 11.5 clone: Build/Scripts/runTests.sh -s functional -p 8.1 typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php self::assertSame('2', $overlaidRecord['_LOCALIZED_UID']); Fails on php 8.1, but succeeds on php 7.4 + 8.0 self::assertSame(2, $overlaidRecord['_LOCALIZED_UID']); Succeeds on php 8.1, but fails on php 7.4 + 8.0 --- In the pipeline for Patchset 3 the functional tests with php 8.0 succeed... -
André Buchmann commented on patch set 4 06/09/22, 05:54
PageRepositoryTest.php:629ReplyUsing mariadb or postgres with any of the 3 php versions will return an int. But with sqlite the return type differs as described in the previous comment. -
Oliver Klee commented on patch set 4 V +1 CR +1 06/09/22, 07:43
PageRepositoryTest.php:629ReplyAh, thanks for the explanation! Then we should indeed keep the int cast. -
Benni Mack voted on patch set 4 V +2 CR +2 06/09/22, 14:37
-
Benni Mack merged patch set 5 06/09/22, 14:37