Review 10.4 Merged

74837[BUGFIX] Apply empty values in language-overlay

Benni Mack CR +2 V +2 Normal +53 −1 updated 06/14/22, 06:56

Commit message

Some default fields (e.g. tt_content.bodytext) can contain null values.
TYPO3 first fetches the data in the default language and then overlays
the rows data with the translation values. The overlay method inspects
each array item with the php isset() function. This validates not only
the existence of the array key, but also the values. null and
false values evaluated as false. Empty strings evaluate as true.
This leads to inconsistent output in the frontend.

The overlay now valides only the array key existence and applies also
empty values.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • André Buchmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • André Buchmann +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Benni Mack commented on patch set 1 06/09/22, 14:37

    Cherry Picked from branch 11.5. The following files contain Git conflicts: * typo3/sysext/core/Tests/Functional/Fixtures/pages.csv
  2. Benni Mack commented on patch set 2 06/09/22, 14:38

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 06/09/22, 14:38

  4. core-ci voted on patch set 1 V -1 06/09/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27893

  5. core-ci voted on patch set 2 V -1 06/09/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27894

  6. André Buchmann uploaded patch set 3 06/10/22, 22:13

  7. André Buchmann uploaded patch set 4 06/10/22, 22:14

  8. core-ci voted on patch set 3 V +1 06/10/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27957

  9. André Buchmann commented on patch set 4 V +1 CR +1 06/10/22, 22:21

    pages.xml:187

    @Benni: removed pages.csv and created the necessary tt_content data in pages.xml
  10. core-ci voted on patch set 4 V +1 06/10/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27958

  11. Oliver Klee voted on patch set 4 CR +1 06/10/22, 22:58

  12. Benni Mack voted on patch set 4 V +2 CR +2 06/14/22, 06:56

  13. Benni Mack merged patch set 5 06/14/22, 06:56