Review 11.5 Merged

75059[BUGFIX] Fix type annotations concerning storage folder identifiers

Stefan Bürk CR +2 V +2 Easy +12 −11 updated 07/07/22, 19:52

Commit message

Storage folder identifiers can also be int-like strings, which causes
them to automatically get cast to int when used as array keys.

Our types annotations need to reflect this in order to keep developers
and static analysis for taking those array keys to be always strings
(which can lead to type errors and has recently done so).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6