TYPO3 Forger
  • Dashboard
  • Get involved
  • Reviews
    Overview Ready for review Work in progress Needs action Needs review Needs verification Needs rebase Negative votes Reviewed and verified Ready to merge
  • Issues
    Stale issues Possible duplicates By category By month
  • Sprints
    Overview Initiatives TYPO3 Core Review board
  • Tools
    Backports ReST helper
  • Help
  • Search
  • Login
Esc

Words find the open ones, a number the issue and the change with it.

  1. Issues
  2. #97858
Issue Task Closed

#97858Improve type annotations regarding storage folder names

Oliver Klee 07/05/22, 09:53 updated 10/04/22, 08:39

Open in Forge Comment in Forge

Description

Storage folder names can also be int-like string, which causes them to be autoconverted to ints when used as array key. This recently has lead to a bug. We should make our code more explicit to help static code analysis and devs avoid this problem in the future.

Reviews 2

  • 11.5 75059[BUGFIX] Fix type annotations concerning storage folder identifiers Resolves this issue Merged Stefan Bürk CR +2 V +2 → main Easy +12 −11 07/07/22, 19:52
  • main 75033[BUGFIX] Fix type annotations concerning storage folder identifiers Resolves this issue Merged Oliver Klee CR +2 V +2 → 11.5 Easy +12 −11 07/07/22, 19:38

Related issues 3

  • Task #97711Improve the return type annotation of ListUtility::resolveSpecialFolderNames Related to Closed Code Cleanup v12 Oliver Klee 05/31/22, 10:35
  • Bug #9785111.5.13-dev: prepareFolderInformation(): Argument #2 ($alternativeName) must be of type ?string, int given Related to Closed v11 Sabrina Hess 07/04/22, 13:44
  • Task #97859Annotate that methods from InaccessibleFolder never return Blocked by Closed Code Cleanup v12 Oliver Klee 07/05/22, 10:17
Author
Oliver Klee
Priority
Should have
Category
Code Cleanup
Target version
12 LTS
TYPO3 version
12
© 2026 TYPO3 GmbH.
  • API
  • Privacy Policy
  • Legal Notice
  • Feedback