Review 11.5 Merged

75367[TASK] Extract url generation in ext:workspaces

Benni Mack CR +2 V +2 Easy +8 −2 updated 08/12/22, 08:40

Commit message

Patch extracts generating url for workspaces
in order to better integrate with external extensions,
so when external extension want to replace url,
extension does not have to override whole handleRequest method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Benni Mack commented on patch set 1 08/10/22, 15:01

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Controller/PreviewController.php
  2. Benni Mack commented on patch set 2 08/10/22, 15:04

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 08/10/22, 15:04

    Published edit on patch set 2.
  4. Benni Mack marked it ready for review 08/10/22, 15:04

  5. core-ci voted on patch set 3 V +1 08/10/22, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30017

  6. core-ci voted on patch set 1 V -1 08/10/22, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30015

  7. core-ci voted on patch set 2 V -1 08/10/22, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30016

  8. Benni Mack updated the commit message in patch set 4 08/10/22, 15:39

  9. core-ci voted on patch set 4 V +1 08/10/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30022

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 08:25

  11. Benni Mack voted on patch set 4 V +2 CR +2 08/12/22, 08:40

  12. Benni Mack merged patch set 5 08/12/22, 08:40