Review main Merged

75853[TASK] Streamline FormEngine inline-relation JavaScript module loading

Benjamin Franzke CR +2 V +2 Normal +11 −135 updated 09/23/22, 10:48

Commit message

Support for non JavaScriptModuleInstruction RequireJS invocations
in FormEngine has been dropped in #96221, but the special ajax
inline-relation was kept by accident. This is now streamlined to
throw the same exception that FormResultCompiler throws for non
JavaScriptModuleInstructions.

Also the internal FormResultTrait is removed as
serializeJavaScriptModuleInstructionItems() is no longer used.
(Note that is was already unused, as the only remaing user
createExecutableStringRepresentationOfRegisteredRequireJsModules()
was only called with skipInstructions=true which skipped the
serialization in favor of direct JavaScriptItem passing).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 8